Skip to content

fix: misc issues with unified expression filter - #9886

Merged
AdityaHegde merged 2 commits into
mainfrom
fix/unified-expr-filter-fixes
Sep 16, 2026
Merged

AdityaHegde merged 2 commits into
mainfrom
fix/unified-expr-filter-fixes

Conversation

@AdityaHegde

@AdityaHegde AdityaHegde commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Fixing issues with the unified expression filter changes.

  1. Refreshing a canvas with filters doesnt add the filter anymore. Was missing metricsViewsProvider.ready check.
  2. Removing an empty filter doesnt remove the pill. Needs an explicit handling since it doesnt go through expr change cycle.
  3. Fix canvas reports not forwarding canvasStateOverride

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@nishantmonu51

Copy link
Copy Markdown
Collaborator

Could we replay pending filter params once metricsViewsProvider.ready becomes true? The report editor uses CanvasProvider with isolated/urlStateOverride without CanvasDashboardWrapper, so there is no syncStoreWithSource to recover the skipped update. With cached dimension specs and a pending time summary, saved filters remain missing after readiness; a targeted test fails with this guard and passes when only the guard is removed. Saving can then drop the captured metricsViewFilters used for report row restrictions. Please cover this isolated report-editor path.

@AdityaHegde

Copy link
Copy Markdown
Collaborator Author

Doing a narrow fix for now by adding a simple component that replays for reports. Will standardise this once time controls have been moved in my other PR

@AdityaHegde
AdityaHegde merged commit d1594b3 into main Sep 16, 2026
10 checks passed
@AdityaHegde
AdityaHegde deleted the fix/unified-expr-filter-fixes branch September 16, 2026 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants