Skip to content

Docs video mp4 fix - #804

Merged
bcolloran merged 5 commits into
mainfrom
docs-video-mp4-fix
Aug 24, 2022
Merged

bcolloran merged 5 commits into
mainfrom
docs-video-mp4-fix

Conversation

@godzig

@godzig godzig commented Aug 19, 2022 •

Copy link
Copy Markdown
Contributor

Turns out mp4s only render on Github if they're included as markdown links. While gifs need to be included as markdown attached files to rendering on Github.

This fix catches both of those variations and will embed Vimeo on the docusaurus side.

I also went through and fixed some of the old broken video links.

@godzig
godzig requested a review from magorlick August 19, 2022 01:29
@godzig
godzig requested a review from bcolloran August 19, 2022 18:23
@bcolloran
bcolloran merged commit b1c29aa into main Aug 24, 2022
@bcolloran
bcolloran deleted the docs-video-mp4-fix branch August 24, 2022 16:05
djbarnwal pushed a commit that referenced this pull request Aug 3, 2023
* overriding link component to fix mp4s

* updating broken video links

Co-authored-by: bcolloran <brendan@colloran.net>
himadrisingh added a commit that referenced this pull request Oct 5, 2026
…9986)

Fixes Dependabot alerts:
- #797, #811: github.com/containerd/containerd/v2 -> v2.2.9
- #804: go.opentelemetry.io/otel/sdk -> v1.45.0
- #805: go.opentelemetry.io/otel/exporters/otlp/otlptrace -> v1.45.0
- #806: go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc -> v1.45.0
- #807: go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp -> v1.45.0

Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
nishantmonu51 pushed a commit that referenced this pull request Oct 6, 2026
…9986)

Fixes Dependabot alerts:
- #797, #811: github.com/containerd/containerd/v2 -> v2.2.9
- #804: go.opentelemetry.io/otel/sdk -> v1.45.0
- #805: go.opentelemetry.io/otel/exporters/otlp/otlptrace -> v1.45.0
- #806: go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc -> v1.45.0
- #807: go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp -> v1.45.0

Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants