Add `svelte-query` by AdityaHegde · Pull Request #752 · rilldata/rill

AdityaHegde · 2022-08-09T16:01:40Z

No description provided.

ericpgreen2 · 2022-08-16T04:30:04Z

Here's some suggestions for naming – so we can start aligning with the MetricView entity type and avoid having the RillRuntime prefix in too many places:

Rename file RillRuntimeMetricsController.ts to MetricViewController.ts
Rename file RillRuntimeMetricsActions.ts to MetricViewActions.ts
Rename action getRuntimeTimeSeries to getMetricViewTimeseries
Rename action getRuntimeMetricsMeta to getMetricViewMeta
Rename action getRuntimeTopList to getMetricViewToplist
Rename type RuntimeMetricsMetaResponse to MetricViewMetaResponse

I think we can remove this old file:

Delete MetricsExplorerActions.ts

I ran into these errors in RillRuntimeMetricsActions.ts:

Property 'getManyByField' does not exist on type 'MeasureDefinitionStateService'.
Property 'getRawResponse' does not exist on type 'typeof ActionResponseFactory'.
TypeError: Cannot read properties of undefined (reading 'metricDefLabel') at RillRuntimeMetricsActions.getRuntimeMetricsMeta (/Users/ericgreen/Desktop/Rill/Code/rill-developer/src/common/rill-developer-service/RillRuntimeMetricsActions.ts:111:39)

Let's use api/v1/metric-views/{view-name}/ as a prefix for each of these APIs

ericpgreen2 · 2022-08-16T04:33:30Z

And as mentioned, to make it easier to review, let's split out this backend PR from each of the frontend PRs:

one for /meta: svelte-query-meta
one for /timeseries: svelte-query-timeseries
one for /toplist
one for /big-number

…type into svelte-query

AdityaHegde · 2022-08-16T10:24:09Z

Updated the names.

Splitting this PR would duplicated the changes to add the endpoint. I feel we should have a PR with outline of the backend here and the UI changes will come in later PRs.

We cannot remove MetricsExplorerActions until everything has been moved to use the new endpoints. This will come after the final PR has been merged.

I have added api/v1. But i feel using view name instead of ID doesnt make sense. We can change the minute details in later PRs.

The errors you got were probably because of cached type definitions. Open the classes where they are defined and it will get fixed. They work without issues for me and also compiles without issues.

ericpgreen2 · 2022-08-16T19:46:54Z

Regarding the PR split, that's what I meant – keep this as the backend PR, and do the frontend work in different PRs.

Using metricViewId not metricViewName sounds good to me.

* Create `lib/svelte-query/queries` directory * Add `svelte-query` `QueryClient` * Bugfix * Call `/meta` via `svelte-query` (WIP) * Change query key format * Refactor `LeaderboardDisplay` to use `/meta` API * Avoid "missing queryFn" error log * Use vanilla fetch * Remove log * Use `/meta` for list of measures * Update `esbuild` * Use new type name * Remove client-side validation (tmp bugfix) * Call `svelte-query` for valid measures and dimensions * Add `TODO` for OpenAPI client code generation * Update comment

* Create `lib/svelte-query/queries` directory * Add `svelte-query` `QueryClient` * Bugfix * Add query key and function for `/timeseries` API * Call `/meta` via `svelte-query` (WIP) * Change query key format * Refactor `LeaderboardDisplay` to use `/meta` API * Avoid "missing queryFn" error log * Use vanilla fetch * Remove log * Remove unused code * Use `/meta` for list of measures * Update `esbuild` * Add query to `timeseries` endpoint * Call `timeseries` endpoint via `svelte-query` * Use new type name * Remove client-side validation (tmp bugfix) * Call `svelte-query` for valid measures and dimensions * Add `TODO` for OpenAPI client code generation * Update comment * Use updated type names * Clean up * Invalidate `/timeseries` query when time controls change * updating og:image (#760) * Revert "Merge branch 'main' into svelte-query-timeseries" This reverts commit 2b68e54, reversing changes made to a13c8d6. Co-authored-by: Mike Godwin <1851282+godzig@users.noreply.github.com> Co-authored-by: Aditya Hegde <adityahegderocks@gmail.com>

ericpgreen2 · 2022-08-19T18:12:15Z

TODOs:

Eliminate line chart jank
Add /totals API and query it via svelte-query
Fix CI/CD errors
Try wrapping the svelte-query boilerplate for more concise component code

* Moving big number to svelte-query * Adding timeseries to invalidation

* Moving to svelte store for explorer * Changing the svelte store usage pattern * Fixing a few issues * Updating names

…oper into svelte-query

* Use explicit `svelte-query` for leaderboards * refactors back toward basic svelte query usage * renames the top list query to useTopListQuery * Better naming * Refactor `useTotalsQuery` * updates Totals query; removes unneeded usage of invalidateMetricViewData * Remove `queriesRepository` layer from `useMetaQuery` * Set better `refetchOnX` values * Remove `queriesRepository` layer from `useTimeSeriesQuery` * Remove `QueriesRepository.ts` * Set `refetchOnReconnect` and `refetchOnWindowFocus` back to `true` * Fix `WHERE` clause generation * Adding optional query profile emitting (#819) * Adding optional query profile emitting * Addressing PR comments * Fixing quick metrics modal missing buttons (#859) * enables negative timeseries (#850) Co-authored-by: Dhiraj Barnwal <sumankumaribarnwal@gmail.com> * adds calendar icon; fixes spacing in dashboard header (#856) * adds calendar icon; fixes spacing in dashboard header * tightens up dashboard header * re-instates spacing for dashboard CTA Co-authored-by: Marissa Gorlick <magorlick@gmail.com> * Fixing edge cases with modifying models Co-authored-by: Hamilton Ulmer <hamilton.ulmer@gmail.com> Co-authored-by: Aditya Hegde <adityahegderocks@gmail.com> Co-authored-by: Dhiraj Barnwal <sumankumaribarnwal@gmail.com> Co-authored-by: Marissa Gorlick <magorlick@gmail.com>

…xisting dashboard

hamilton

lgtm

* Adding svelte-query * Adding reactive query update * Adding backend APIs based on new specs * Removing dev routes * Renaming * Fix endpoint paths * Adding validation to /meta endpoint * Renaming and fixing sqlName * Renaming filter * Query the `/meta` API via `svelte-query` (#801) * Create `lib/svelte-query/queries` directory * Add `svelte-query` `QueryClient` * Bugfix * Call `/meta` via `svelte-query` (WIP) * Change query key format * Refactor `LeaderboardDisplay` to use `/meta` API * Avoid "missing queryFn" error log * Use vanilla fetch * Remove log * Use `/meta` for list of measures * Update `esbuild` * Use new type name * Remove client-side validation (tmp bugfix) * Call `svelte-query` for valid measures and dimensions * Add `TODO` for OpenAPI client code generation * Update comment * Query the `/timeseries` API via `svelte-query` (#803) * Create `lib/svelte-query/queries` directory * Add `svelte-query` `QueryClient` * Bugfix * Add query key and function for `/timeseries` API * Call `/meta` via `svelte-query` (WIP) * Change query key format * Refactor `LeaderboardDisplay` to use `/meta` API * Avoid "missing queryFn" error log * Use vanilla fetch * Remove log * Remove unused code * Use `/meta` for list of measures * Update `esbuild` * Add query to `timeseries` endpoint * Call `timeseries` endpoint via `svelte-query` * Use new type name * Remove client-side validation (tmp bugfix) * Call `svelte-query` for valid measures and dimensions * Add `TODO` for OpenAPI client code generation * Update comment * Use updated type names * Clean up * Invalidate `/timeseries` query when time controls change * updating og:image (#760) * Revert "Merge branch 'main' into svelte-query-timeseries" This reverts commit 2b68e54, reversing changes made to a13c8d6. Co-authored-by: Mike Godwin <1851282+godzig@users.noreply.github.com> Co-authored-by: Aditya Hegde <adityahegderocks@gmail.com> * Adding svelte-query to leaderboards (#806) * Move time range logic from Redux to components (WIP) * Moving big number to svelte-query (#817) * Moving big number to svelte-query * Adding timeseries to invalidation * Use a Svelte store for the metrics explorer (#820) * Moving to svelte store for explorer * Changing the svelte store usage pattern * Fixing a few issues * Updating names * Merge `main` into `svelte-query` * Update package.json * Update `package-lock.json` * Revert regressions in docs * Move function into the file it's used in * Fix lint errors * Fix linechart jank (#823) * Moving to svelte store for explorer * Add guard to prevent re-renders * Ensure we only make valid time ranges Co-authored-by: Aditya Hegde <adityahegderocks@gmail.com> * Remove old Redux code (#825) Co-authored-by: Aditya Hegde <adityahegderocks@gmail.com> * Remove explore redux (#826) * Removing remaining explore redux code * Fix import * Removing unnecessary fields from explore Co-authored-by: greenep12 <ericpgreen2@gmail.com> * Fix API bugs and tests (#836) * Fixing API bugs and tests * Remove TODO Co-authored-by: greenep12 <ericpgreen2@gmail.com> * Bugfix * Create concise custom query hooks (#829) * Removing remaining explore redux code * Fix import * Use `metricView` terminology * Refactor `svelte-query` call to `/meta` * Refactor `svelte-query` call to `/timeseries` * Refactor `svelte-query` call to `/toplist` * Refactor `svelte-query` call to `/totals` * Ensure queries don't run with undefined parameters * Mini refactor * Add request parameters to query keys (recommended in docs) * Fix error message * Fix animation bug * Avoid error when `metricsExplorer` is undefined * Ensure `offset == 0` doesn't disable the query * Various fixes * Fixing a few issues with reactivity * Remove buggy animation * Handling case where dimension is deleted Co-authored-by: Aditya Hegde <adityahegderocks@gmail.com> * Fix time controls state when switching dashboards * Fix lint * Fix time control state (take 2) * Add `TODO` * Refine the loading animation for leaderboards (#848) * refines the loading animation for leaderboards * replaces data only after fetch is complete * Gray the leaderboard numbers during loading Co-authored-by: greenep12 <ericpgreen2@gmail.com> * Fix key for self-managed query cache * Restore types to custom query hooks * Fixing null totals values * Fixing reactive statement for reference values * Fixing null values not being marked as active * Fixing humanise values * Fixing reference value being undefined during query * Fixing reference value being undefined during query * Fixing build * Use `refetchOnMount: true` globally * Remove `QueriesRepository.ts` layer (#857) * Use explicit `svelte-query` for leaderboards * refactors back toward basic svelte query usage * renames the top list query to useTopListQuery * Better naming * Refactor `useTotalsQuery` * updates Totals query; removes unneeded usage of invalidateMetricViewData * Remove `queriesRepository` layer from `useMetaQuery` * Set better `refetchOnX` values * Remove `queriesRepository` layer from `useTimeSeriesQuery` * Remove `QueriesRepository.ts` * Set `refetchOnReconnect` and `refetchOnWindowFocus` back to `true` * Fix `WHERE` clause generation * Adding optional query profile emitting (#819) * Adding optional query profile emitting * Addressing PR comments * Fixing quick metrics modal missing buttons (#859) * enables negative timeseries (#850) Co-authored-by: Dhiraj Barnwal <sumankumaribarnwal@gmail.com> * adds calendar icon; fixes spacing in dashboard header (#856) * adds calendar icon; fixes spacing in dashboard header * tightens up dashboard header * re-instates spacing for dashboard CTA Co-authored-by: Marissa Gorlick <magorlick@gmail.com> * Fixing edge cases with modifying models Co-authored-by: Hamilton Ulmer <hamilton.ulmer@gmail.com> Co-authored-by: Aditya Hegde <adityahegderocks@gmail.com> Co-authored-by: Dhiraj Barnwal <sumankumaribarnwal@gmail.com> Co-authored-by: Marissa Gorlick <magorlick@gmail.com> * Fix bug where measure edits aren't reflected in Explore * Fix lint * Invalidate `/meta` when deleting measures and dimensions * Remove unused props * Remove unused prop * Use previous time controls when switching from a source/model to an existing dashboard Co-authored-by: greenep12 <ericpgreen2@gmail.com> Co-authored-by: Mike Godwin <1851282+godzig@users.noreply.github.com> Co-authored-by: Hamilton Ulmer <hamilton.ulmer@gmail.com> Co-authored-by: Dhiraj Barnwal <sumankumaribarnwal@gmail.com> Co-authored-by: Marissa Gorlick <magorlick@gmail.com>

AdityaHegde added 3 commits August 9, 2022 21:31

Adding svelte-query

b226651

Adding reactive query update

494ce2b

Adding backend APIs based on new specs

0cbf55a

AdityaHegde force-pushed the svelte-query branch from 9bb80fb to 0cbf55a Compare August 15, 2022 13:39

Merge branch 'main' into svelte-query

ebb8dcc

AdityaHegde added 2 commits August 16, 2022 15:42

Removing dev routes

df01451

Merge branch 'svelte-query' of github.com:rilldata/data-modeler-proto…

6921b51

…type into svelte-query

AdityaHegde added 2 commits August 16, 2022 15:54

Renaming

809a0c8

Merge branch 'main' into svelte-query

20eb811

ericpgreen2 and others added 10 commits August 16, 2022 15:42

Fix endpoint paths

8b9317e

Merge branch 'main' into svelte-query

66e67e5

Adding validation to /meta endpoint

1c908f2

Renaming and fixing sqlName

a92e228

Merge branch 'main' into svelte-query

659f202

Renaming filter

6c6bedb

Merge branch 'main' into svelte-query

1263940

Adding svelte-query to leaderboards (#806)

893e3eb

ericpgreen2 changed the title ~~Adding svelte-query~~ Add svelte-query Aug 19, 2022

ericpgreen2 changed the title ~~Add svelte-query~~ Add svelte-query Aug 19, 2022

Merge branch 'main' into svelte-query

d1b3bf8

ericpgreen2 and others added 3 commits August 21, 2022 22:12

Move time range logic from Redux to components (WIP)

9daa992

Moving big number to svelte-query (#817)

5d812bf

* Moving big number to svelte-query * Adding timeseries to invalidation

Use a Svelte store for the metrics explorer (#820)

3dba180

* Moving to svelte store for explorer * Changing the svelte store usage pattern * Fixing a few issues * Updating names

ericpgreen2 and others added 10 commits August 29, 2022 22:01

Merge branch 'svelte-query' into svelte-query-caching

ba9260e

Merge branch 'main' into svelte-query

e46c979

Restore types to custom query hooks

7f2e404

Fixing null totals values

c2d8069

Fixing reactive statement for reference values

8abc1ab

Fixing null values not being marked as active

97cce7b

Fixing humanise values

b99c0b0

Fixing reference value being undefined during query

f0575e5

Merge branch 'svelte-query' into svelte-query-caching

932cba8

Fixing reference value being undefined during query

25b8fc6

AdityaHegde force-pushed the svelte-query branch from f0575e5 to 25b8fc6 Compare August 30, 2022 14:26

AdityaHegde and others added 12 commits August 30, 2022 20:01

Fixing build

e17de13

Use refetchOnMount: true globally

0df13c7

Merge branch 'svelte-query' of https://github.com/rilldata/rill-devel…

4cb88ce

…oper into svelte-query

Merge branch 'main' into svelte-query

1e9a60d

Merge branch 'main' into svelte-query

9e5e0e5

Fix bug where measure edits aren't reflected in Explore

67bcf4c

Fix lint

18f1ae8

Invalidate /meta when deleting measures and dimensions

dda0862

Remove unused props

ca3925f

Remove unused prop

ff0bbb9

Use previous time controls when switching from a source/model to an e…

94939ab

…xisting dashboard

ericpgreen2 marked this pull request as ready for review August 31, 2022 22:21

hamilton self-requested a review August 31, 2022 23:01

hamilton approved these changes Aug 31, 2022

View reviewed changes

hamilton merged commit 218c421 into main Aug 31, 2022

hamilton deleted the svelte-query branch August 31, 2022 23:02

ericpgreen2 mentioned this pull request Sep 1, 2022

Use "metrics view" not "metric view" terminology #871

Merged

Navigation Menu

Repository navigation

Add `svelte-query` - #752

Add `svelte-query`#752
hamilton merged 65 commits into
mainfrom
svelte-query

AdityaHegde commented Aug 9, 2022

Uh oh!

ericpgreen2 commented Aug 16, 2022 •

edited

Loading

Uh oh!

ericpgreen2 commented Aug 16, 2022 •

edited

Loading

Uh oh!

AdityaHegde commented Aug 16, 2022 •

edited

Loading

Uh oh!

ericpgreen2 commented Aug 16, 2022

Uh oh!

ericpgreen2 commented Aug 19, 2022 •

edited

Loading

Uh oh!

hamilton left a comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

AdityaHegde commented Aug 9, 2022

Uh oh!

ericpgreen2 commented Aug 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ericpgreen2 commented Aug 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AdityaHegde commented Aug 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ericpgreen2 commented Aug 16, 2022

Uh oh!

ericpgreen2 commented Aug 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hamilton left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ericpgreen2 commented Aug 16, 2022 •

edited

Loading

ericpgreen2 commented Aug 16, 2022 •

edited

Loading

AdityaHegde commented Aug 16, 2022 •

edited

Loading

ericpgreen2 commented Aug 19, 2022 •

edited

Loading