Skip to content

feat: add email attachment support in alerts - #10060

Merged
AdityaHegde merged 4 commits into
mainfrom
feat/alert-email-attachments
Oct 29, 2026
Merged

AdityaHegde merged 4 commits into
mainfrom
feat/alert-email-attachments

Conversation

@AdityaHegde

@AdityaHegde AdityaHegde commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

Follow up to #10031. Adds similar attachment support in alerts. Since alerts dont have export support, adding export related config when attach is toggled on.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@nishantmonu51

Copy link
Copy Markdown
Collaborator

[P2] Preserve failure notifications when attachment export times out — runtime/reconcilers/alert.go:1031
An attachment export timeout returns before email or Slack delivery. The detected failure becomes an error; because on_error defaults to false, recipients receive no notification, and interval alerts advance past that execution. Deliver without the attachment or retain the failure for retry.

[P2] Skip attachment validation when attachments are disabled — web-common/src/features/alerts/form-utils.ts:169
An invalid row limit continues blocking saves after attachments or email delivery are disabled and its input is hidden. Validate only when enabled, or clear the unused limit.

@nishantmonu51

Copy link
Copy Markdown
Collaborator

⚠️ Review paused: current-head checks did not pass

The current head 1e67030cf8b7 has checks that did not pass, so no review conversation was started:

  • e2e (web-local)

Fix the checks above and push. The scheduled scan then starts the review on the updated head.

This is an automated check - no AI was used to generate this comment.

@AdityaHegde
AdityaHegde merged commit 0eef2ae into main Oct 29, 2026
20 of 21 checks passed
@AdityaHegde
AdityaHegde deleted the feat/alert-email-attachments branch October 29, 2026 10:54
nishantmonu51 pushed a commit that referenced this pull request Oct 29, 2026
* feat: add email attachment support in alerts

* Self review

* PR comments

(cherry picked from commit 0eef2ae)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants