Skip to content

skip live OLAP queries in health checks - #10057

Merged
k-anshul merged 1 commit into
mainfrom
skip_live_queries
Oct 23, 2026
Merged

k-anshul merged 1 commit into
mainfrom
skip_live_queries

Conversation

@k-anshul

@k-anshul k-anshul commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Live OLAP queries have several cons:

  1. Creates lot of noise for incorrect user configurations.
  2. Can wake up services even when caching is on if no health check passes. Caching TBH defeats the whole purpose as well.
  3. As Rill grows the onus should be on user to monitor their projects and Rill should only check for system errors. A follow up that allows users to monitor reconcile alerts easily be raised after this.
  4. Can be enabled selectively for some projects.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@k-anshul k-anshul self-assigned this Oct 23, 2026
@k-anshul
k-anshul requested a review from himadrisingh October 23, 2026 07:48
@k-anshul
k-anshul requested a review from pjain1 October 23, 2026 07:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

A configuration decoding error in one instance now aborts the aggregate health response for the runtime.

1 open issue
What changed in this PR

This PR makes live OLAP health probes opt-in, reducing queries caused by health checks while retaining controller, repository, and reconciliation checks.

Changes:

  • Adds rill.health.make_live_queries, defaulting to false.
  • Skips OLAP pings, metrics-view queries, and health-cache updates unless enabled.
  • Updates tests and documents the setting.
File Description
runtime/​parser/​schema/​rillyaml.schema.yaml Defines the new boolean setting and its default.
runtime/​health.go Gates live probes and cache updates on the setting.
runtime/​health_test.go Covers enabled and default-disabled health checks.
runtime/​drivers/​registry.go Adds the instance configuration field.
docs/​docs/​reference/​project-files/​rill-yaml.md Documents the opt-in setting.

Review effort: Balanced

Comment thread runtime/health.go Resolved
@k-anshul
k-anshul merged commit fb44993 into main Oct 23, 2026
21 checks passed
@k-anshul
k-anshul deleted the skip_live_queries branch October 23, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants