Repository navigation
skip live OLAP queries in health checks - #10057
Merged
Merged
Conversation
nishantmonu51
approved these changes
Oct 23, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
A configuration decoding error in one instance now aborts the aggregate health response for the runtime.
1 open issue
What changed in this PR
This PR makes live OLAP health probes opt-in, reducing queries caused by health checks while retaining controller, repository, and reconciliation checks.
Changes:
- Adds
rill.health.make_live_queries, defaulting to false. - Skips OLAP pings, metrics-view queries, and health-cache updates unless enabled.
- Updates tests and documents the setting.
| File | Description |
|---|---|
| runtime/parser/schema/rillyaml.schema.yaml | Defines the new boolean setting and its default. |
| runtime/health.go | Gates live probes and cache updates on the setting. |
| runtime/health_test.go | Covers enabled and default-disabled health checks. |
| runtime/drivers/registry.go | Adds the instance configuration field. |
| docs/docs/reference/project-files/rill-yaml.md | Documents the opt-in setting. |
Review effort: Balanced
k-anshul
added a commit
that referenced
this pull request
Oct 23, 2026
k-anshul
added a commit
that referenced
this pull request
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Live OLAP queries have several cons:
Checklist: