Skip to content

Partially fix compatibility with Visual Studio 2019 - #1

Closed
chenxiaolong wants to merge 1 commit into
rileytestut:masterfrom
chenxiaolong:vs2019
Closed

Partially fix compatibility with Visual Studio 2019#1
chenxiaolong wants to merge 1 commit into
rileytestut:masterfrom
chenxiaolong:vs2019

Conversation

@chenxiaolong

Copy link
Copy Markdown

This adds a missing <codecvt> include and switches switches from auto_ptr to unique_ptr.

This doesn't completely allow the project to be built with VS2019. ldid also needs to target C++17 and use std::filesystem instead of std::experimental::filesystem. I didn't include this change in the PR because I'm not sure if it'll break compilation with earlier versions of MSVC.

diff --git a/ldid/ldid.cpp b/ldid/ldid.cpp
index 3e30220..de7b61f 100755
--- a/ldid/ldid.cpp
+++ b/ldid/ldid.cpp
@@ -70,7 +70,7 @@
 
 #include <filesystem>
 
-namespace fs = std::experimental::filesystem;
+namespace fs = std::filesystem;
 
 #ifdef __APPLE__
 #include <CommonCrypto/CommonDigest.h>
diff --git a/ldid/ldid.vcxproj b/ldid/ldid.vcxproj
index f23c5fe..3c72e39 100755
--- a/ldid/ldid.vcxproj
+++ b/ldid/ldid.vcxproj
@@ -107,7 +107,7 @@
       <ConformanceMode>true</ConformanceMode>
       <PrecompiledHeaderFile>pch.h</PrecompiledHeaderFile>
       <AdditionalIncludeDirectories>$(ProjectDir)..\Dependencies\dirent\include;$(ProjectDir)..\Dependencies\libimobiledevice-vs\libplist\include;$(ProjectDir)..\AltSign\Dependencies\regex\include;$(ProjectDir)..\AltSign\Dependencies\mman;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
-      <LanguageStandard>stdcpp14</LanguageStandard>
+      <LanguageStandard>stdcpp17</LanguageStandard>
     </ClCompile>
     <Link>
       <SubSystem>Windows</SubSystem>

Signed-off-by: Andrew Gunnerson <andrewgunnerson@gmail.com>
@ghost

ghost commented Dec 29, 2019

Copy link
Copy Markdown

Sir, can you please share build instructions? I am very stuck

@lonkelle

lonkelle commented Jul 2, 2021

Copy link
Copy Markdown
Collaborator

@rileytestut Do you use VS 2019 to compile AltServer for Windows? Is this worth looking into - someone did approve it on Feb 2nd of this year.

@lonkelle

lonkelle commented Jul 2, 2021

Copy link
Copy Markdown
Collaborator

Imma just close it for now since this conflicts anyway now.

@lonkelle lonkelle closed this Jul 2, 2021
XPZooo added a commit to XPZooo/AltServer-Windows that referenced this pull request Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants