Repository navigation
Take the closed-signup help picture at phone width - #730
Conversation
The "what people see" picture on "Close or reopen a signup" was taken on a computer (1408×680), so a 390px phone scaled it to about half size and its text came out around 7px tall. The walkthrough now opens the visitor's page at 390×844 for that picture, and the article gives its new size (390×371). The other two pictures are unchanged. Fixes #652. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016YZ9SZ9SWBo9eD
|
CI is green on Correction: the Generated by Claude Code |
Tophat: passedI ran
For the owner (UX): the help page "Close or reopen a signup" now shows what people see on a closed signup the way a phone shows it. At phone width the signup's title wraps to two lines, so the picture is taller. On a computer it's about 390px wide instead of filling the column. To compare, see Screenshots are in https://claude.ai/code/session_016YZ9STezWbCwraoLkr1hSJ. Generated by Claude Code |
richshaw
left a comment
There was a problem hiding this comment.
Review: passed (round 1)
The PR re-takes the "what people see" picture on the help page "Close or reopen a signup" at phone width, as #652 asks. The walkthrough opens the visitor's page at 390×844 with deviceScaleFactor: 2, and the article's <Screenshot> is now 390×371, half the new 780×742 file. I opened the committed picture: it shows the Closed box with "This signup is no longer collecting responses.", the title, and Closed on Fruit and water and Orange slices, so the alt text still matches. The walkthrough's checks on that page (Closed at the top, Closed on both slots, no Sign up) now run at phone size and pass in CI. Every "Fix, in outline" and "Done when" item in #652 is done, and the CHANGELOG line is under Unreleased › Changed.
Blocking (0): none
Optional (0): none
Earlier threads: none. Copilot couldn't review because the review quota was used up.
Checks: CI is green on 18b761e (lint-type-test, e2e, CodeQL). The tophat passed on this same SHA. I didn't need to run anything locally: the diff is one spec, one article's width and height, a PNG and the CHANGELOG, and src/help/articles.test.tsx checks the picture's size in CI.
For the owner (UX): this changes a help page picture. On a phone it is now readable at full size. On a computer it shows about 390px wide, narrower than the text column, and taller because the title wraps. Compare the tophat's 730-before-phone-picture with 730-after-phone-picture, and 730-before-desktop-picture with 730-after-desktop-picture.
Session: https://claude.ai/code/session_016YZ9SW5JHz4c4y9KsELbN5
Generated by Claude Code
…e-closed-screenshot # Conflicts: # CHANGELOG.md
Fixes #652.
The problem
The "what people see" picture on the help page "Close or reopen a signup" was taken on a computer (1408×680, shown at 704×340). On a 390px phone the page scaled it down to about 356px wide, so "This signup is no longer collecting responses." and each slot's Closed came out about 7px tall. Most people read this article on a phone.
The fix
tests/e2e/help/close-or-reopen-a-signup.spec.ts: the visitor's page for that picture now opens at 390×844 (stilldeviceScaleFactor: 2). The walkthrough's checks on that page (Closed at the top, Closed on both slots, no Sign up) run at that size too.HELP_SCREENSHOTS=1). Onlywhat-people-see.pngchanged. It's now 780×742, and the article shows it at 390×371.At phone width the signup's title wraps to two lines, so the picture is taller than before. On a computer it shows at about 390px wide, narrower than the text column, as the issue expected.
Tests
HELP_SCREENSHOTS=1 pnpm exec playwright test -c .claude/skills/run-opensignup/playwright.container.config.ts tests/e2e/help/close-or-reopen-a-signup.spec.ts --project=chromiumagainst a production build: 2 passed (computer and phone).pnpm lint && pnpm typecheck && pnpm knip && pnpm test: all pass (2021 tests, includingsrc/help/articles.test.tsx, which checks the picture's real size against the article).Generated by Claude Code