Skip to content

feat(manager): share OCI Helm chart resolution across managers - #45760

Draft
secustor wants to merge 2 commits into
mainfrom
feat/oci-helm-chart-dep
Draft

feat(manager): share OCI Helm chart resolution across managers#45760
secustor wants to merge 2 commits into
mainfrom
feat/oci-helm-chart-dep

Conversation

@secustor

@secustor secustor commented Sep 7, 2026

Copy link
Copy Markdown
Member

Changes

Adds getOciChartDep() to lib/modules/manager/helmv3/oci.ts and uses it in every manager that resolves Helm charts stored in OCI registries: argocd, fleet, flux, helmfile, helmsman, helmv3, kustomize, sveltos, terraform (helm_release) and vendir.

The helper strips the oci:// prefix and a trailing slash, resolves registryAliases through the dockerfile manager's getDep(), and returns the docker datasource, the packageName and pinDigests: false. The version fields these managers update cannot carry a digest: Helm only accepts one inside the OCI reference (chart@sha256:..., helm/helm#12690) and Flux HelmCharts take semver only, so a pin attempt failed in auto-replace with "Digest is not updated". Each manager keeps its own depName convention.

Until now every manager carried its own copy of this logic and the copies disagreed, so this PR also changes behaviour:

  • pinDigests: false was only set by fleet, helmv3, kustomize and vendir. argocd, flux, helmfile, helmsman, sveltos and terraform now set it as well, so pinDigests: true no longer produces failing pin attempts. For argocd (already excluded by the docker:pinDigests preset) and terraform (manager default pinDigests: false) the dep-level flag only matters when pinDigests: true is set explicitly.
  • registryAliases were ignored for OCI charts in argocd, helmfile (oci:// charts and oci: true repositories) and helmsman. They now apply the same way as for container images. The registryAliases docs and the argocd and helmsman readmes mention this.
  • terraform joined repository and chart with url-join, which turns oci://registry.example.com:5000/charts into registry.example.com://5000/charts/<chart>. The port is kept now.
  • fleet produced currentValue: 'undefined' for OCI charts without a version. Such charts are now skipped with unspecified-version, like charts from classic repositories.

Context

Please select one of the following:

  • This closes an existing Issue, Closes: #
  • This doesn't close an Issue, but I accept the risk that this PR may be closed if maintainers disagree with its opening or implementation

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI-generated non‑trivial portions of code, tests, or documentation).
  • Yes — other (please describe):

Claude Code (Claude Fable 5.1) wrote the code, tests and documentation changes, starting from an audit of the duplicated OCI chart handling across managers.

Use of AI in replying to PR comments

Who answers review comments:

  • @username will read and reply directly. Name the account.
  • An agent will draft replies and @username will read them before they are posted. Name the account.
  • Nobody has explicitly committed to replying.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests, but ran on a real repository, or
  • Both unit tests + ran on a real repository

Add getOciChartDep() to helmv3/oci.ts and use it in argocd, fleet, flux,
helmfile, helmsman, helmv3, kustomize, sveltos, terraform and vendir.

- set pinDigests: false for OCI charts in all of them
- apply registryAliases to OCI charts in argocd, helmfile and helmsman
- keep the registry port in terraform helm_release repositories
- skip fleet OCI charts without a version instead of using 'undefined'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant