refactor(pr-body): use Important truncation notice across platforms - #45644
Closed
setchy wants to merge 6 commits into
Closed
refactor(pr-body): use Important truncation notice across platforms#45644setchy wants to merge 6 commits into
Important truncation notice across platforms#45644setchy wants to merge 6 commits into
Conversation
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
- Use `codeBlock` template helper for Caution/Important PR body notes - Drop the all-platform truncation notice text change (moved to separate PR) - Remove GitHub truncation-notice test depending on the extracted change Signed-off-by: Adam Setch <adam.setch@outlook.com>
Change the PR-body truncation notice from a `Note` to an `Important` alert, and move the scissors emoji into the message body. This is a change that affects all platforms, split out from the GitHub rendered-alerts work. Signed-off-by: Adam Setch <adam.setch@outlook.com>
setchy
changed the title
Important truncation notice across platformsImportant truncation notice across platforms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Change the PR-body truncation notice from a
Notealert to anImportantalert, and move the scissors emoji into the message body, so it renders consistently across all platforms.This all-platforms change was split out of #45613 following review feedback that the truncation notice change should live in its own PR.
Context
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
The change and this PR were produced with assistance from an AI coding agent.
Use of AI in replying to PR comments
Who answers review comments:
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: