Repository navigation
chore(example): bump BGD, COL contract_details schema versions - #1910
Open
gabrielseco wants to merge 1 commit into
Open
gabrielseco wants to merge 1 commit into
gabrielseco wants to merge 1 commit into
Conversation
Workbench-Thread: g-2026-11-09-bump-contract-details-BGD-COL
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
Contributor
|
Deploy preview for adp-cost-calculator ready!
Deployed with vercel-action |
Contributor
Preview employmentsSeeded through https://remote-flows-nf2jdzlr9-remotecom.vercel.app. Each link opens onboarding with the employment prefilled: continue through Select Country and Basic Information to reach Contract Details. |
Contributor
📊 Coverage Report⚪ Coverage unchanged
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the example app's contract details schema version for Bangladesh from v8 to v9 and for Colombia from v6 to v7. In both new versions the probation period is blocked for employees with a recognized seniority date, unless the request comes from a Remote Admin, so partners with custom UIs should send no probation or a zero length for those employees. The migration guides and the version matrix in the README are updated, and baseline snapshots are added for the new versions while the old ones are kept. There is no public API change.
Decisions to review
Why
The example app pins older contract details schema versions for Bangladesh and Colombia, and both countries have newer versions that need to be adopted and documented.
What changed
Files and behaviour (6 files +502 −8)
docs/schema-changes/eor/contract-details/countries/BGD.md+25 −2docs/schema-changes/eor/contract-details/countries/COL.md+26 −2docs/schema-changes/eor/contract-details/countries/README.md+2 −2example/src/flows/Onboarding/jsonSchemaVersions.ts+2 −2snapshots/contract-details/BGD.v9.json+244 −0snapshots/contract-details/COL.v7.json+203 −0Related Resources
Testing
Check: passed (exit 0, 2s)
Note
Low Risk
Documentation, example schema pins, and snapshot baselines only; no application logic changes in this diff.
Overview
Adopts Bangladesh contract details v9 and Colombia v7 in the example onboarding config (
jsonSchemaVersions.ts), and documents both upgrades with migration snippets.BGD v9 blocks probation for employments with a recognized seniority date:
has_probation_periodmust be"no"(or omitted) andprobation_lengthmust be0(unless Remote Admin). Thehas_probation_periodUI becomes a yes/no radio without N/A.COL v7 applies the same seniority-date rule by locking
probation_lengthto0, swaps a custom max-error string for the default message, and adds a help-center link onprobation_length.The country version matrix is updated to v9/v7 (November 2026), and new baseline snapshots
BGD.v9.jsonandCOL.v7.jsonare added alongside prior versions.Reviewed by Cursor Bugbot for commit d97ddf4. Bugbot is set up for automated code reviews on this repo. Configure here.