Repository navigation
docs: document the time-off API contract used by manager flows - #1908
Draft
jordividaller wants to merge 2 commits into
Draft
jordividaller wants to merge 2 commits into
jordividaller wants to merge 2 commits into
Conversation
Record what the generated client says about the manager-side time-off routes (show, list, types, approve, decline, leave policy summary and details): routes, generated names, parameters, response fields, statuses, declared errors, authentication and scopes. List where it differs from the assumed contract and the questions only the live API can answer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Deploy preview for adp-cost-calculator ready!
Deployed with vercel-action |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
Contributor
📊 Coverage Report✅ Coverage increased! 🎉
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a reference page that records what the generated API client says about the time-off endpoints a manager uses to read, approve and decline time-off requests.
Why
The manager time-off work relies on a few contract points that are easy to assume wrongly: whether
approver_idanddecline_reasoncan be null, which statuses exist, which errors are declared, how the list pages. Writing down what the client actually states, and what it does not, keeps those assumptions visible. It also lists the questions only the live API can answer.What changed
Toggle details
docs/TIME_OFF_API_CONTRACT.md. No code change, no public API change.Timeoffrecord fields, the status enum, declared errors, authentication and scopes.approver_idanddecline_reasonare required keys with nullable values; no default or maximum is stated forpage_size; oneapprover_idper record and no approval chain.pageSizeJSDoc onUseTimeOffListOptionssays the API documents1to100with20by default. The generated type for the time-off list does not state this (other list endpoints do).Screenshots
N/A
Related Resources
N/A
Testing
Docs-only change. The page was checked by reading the generated client (
src/client/sdk.gen.ts,src/client/types.gen.ts) and the TimeOff flow code.pnpm run check-formatpasses on the repo with the new file. No build, lint, type check or example app run, since no code changed.example/app in a browser🤖 Generated with Claude Code