Repository navigation
fix(e2e): account for the EA preview step in onboarding specs - #1604
Merged
Merged
Conversation
…ding specs Basic and Portugal onboarding now land on the Preview Employment Agreement step after Benefits. Continue through it before asserting Review. Also give the OnboardingInvite deposit-handling test a 5s findByText timeout: it renders the flow three times in a row and hit the 1s default on a loaded CI runner. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (291 total)
✅ Bundle size check passed |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
|
Deploy preview for adp-cost-calculator ready!
Deployed with vercel-action |
gabrielseco
changed the title
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
Contributor
📊 Coverage Report
|
| Metric | Current | Previous | Change | Status |
|---|---|---|---|---|
| Lines | 89.61% | 89.63% | -0.02% | 🔴 |
| Statements | 89.49% | 89.50% | -0.02% | 🔴 |
| Functions | 88.50% | 88.50% | 0% | ⚪ |
| Branches | 81.30% | 81.32% | -0.02% | 🔴 |
Detailed Breakdown
Lines Coverage
- Covered: 5417 / 6045
- Coverage: 89.61%
- Change: -0.02% (-1 lines)
Statements Coverage
- Covered: 5482 / 6126
- Coverage: 89.49%
- Change: -0.02% (-1 statements)
Functions Coverage
- Covered: 1432 / 1618
- Coverage: 88.50%
- Change: 0% (0 functions)
Branches Coverage
- Covered: 3373 / 4149
- Coverage: 81.30%
- Change: -0.02% (-1 branches)
✅ Coverage check passed
…ing spec Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
cammellos
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the basic, Portugal and Germany onboarding e2e specs that are failing on main.
Why
Both flows now land on a "Preview Employment Agreement" step between Benefits and Review, so the specs timed out waiting for "Review".
What changed
Toggle details
onboard-basic-employee.spec.ts,onboard-portugal-employee.spec.tsandonboard-germany-employee.spec.tsassert the preview step title, click Continue, then assert Review.Screenshots
N/A
Related Resources
Testing
E2E hits the real sandbox, so it is validated by this PR's E2E check.
example/app in a browser🤖 Generated with Claude Code
Note
Low Risk
Test-only changes with no production or API impact.
Overview
Updates three onboarding Playwright specs (basic, Germany, and Portugal employee flows) so they match the current wizard order after Benefits.
Each spec now waits for the Preview Employment Agreement step title, clicks the primary submit button to continue, then proceeds to the existing Review assertions. This fixes timeouts on main where tests expected Review immediately after Benefits.
Reviewed by Cursor Bugbot for commit 79d7a2f. Bugbot is set up for automated code reviews on this repo. Configure here.