Repository navigation
fix(onboarding): normalize times and breaks sent to the daily schedule row update - #1595
Merged
Merged
Conversation
…e row update Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (291 total)
✅ Bundle size check passed |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
Contributor
|
Deploy preview for adp-cost-calculator ready!
Deployed with vercel-action |
…es values Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
📊 Coverage Report✅ Coverage increased! 🎉
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
jordividaller
approved these changes
Oct 16, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Custom daily schedule editors no longer have to reformat times and breaks before updating a row. Times with seconds and numeric breaks are accepted as sent.
Why
A native time input can return
09:00:00, and a partner may send a break as a number. The row update wrote whatever it received, so the value only failed validation later, on blur or save. Partners had to learn the exact stored format and reproduce it themselves.What changed
Toggle details
Not a breaking change and no new exports; the row update keeps its signature.
start_time/end_time: surrounding whitespace is trimmed and seconds are dropped (09:00:00becomes09:00).break_duration_minutes: a number is stored as a string.9:00, is stored as sent, so the existing validation for those is unchanged.Narrowing the value type of the row update from
unknownis left out on purpose: it would be a breaking type change for existing callers.Screenshots
N/A
Related Resources
Testing
Unit tests cover the normalizers and one wiring test covers the row update through the edit state. Removing the normalization call from the row update makes the wiring test fail (
expected '09:00:00' to be '09:00'); I confirmed this and restored the code.example/app in a browser🤖 Generated with Claude Code
Note
Low Risk
Localized onboarding daily-schedule edit-form coercion with no API signature change; validation behavior for invalid partial input is explicitly preserved.
Overview
Daily schedule
updateRownow normalizes values on write so custom editors and native inputs do not need to match the edit form’s stored shape before calling the API.start_time/end_timeare trimmed and seconds are stripped (e.g.09:00:00→09:00);break_duration_minutesaccepts numbers and stores them as strings. Partial or non-HH:mmtimes are left as sent so existing blur/save validation is unchanged. Normalization is implemented in newnormalizeTimeInput/normalizeRowValuehelpers and applied insideuseDailyScheduleEditForm’supdateRow; types doc is updated and unit/integration tests cover the helpers and wiring.Reviewed by Cursor Bugbot for commit 2b49128. Bugbot is set up for automated code reviews on this repo. Configure here.