Skip to content

chore(example): bump GBR contract_details schema version to 7 - #1571

Merged
gabrielseco merged 2 commits into
mainfrom
chore/bump-gbr-contract-details-v7
Oct 14, 2026
Merged

gabrielseco merged 2 commits into
mainfrom
chore/bump-gbr-contract-details-v7

Conversation

@gabrielseco

@gabrielseco gabrielseco commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Partners API integrators onboarding UK employees get the hourly wage type and the daily schedule in the contract details form. The example app is pinned to the new UK schema version.

Blocked: depends on the backend schema change being deployed. Do not merge until it is, otherwise json_schema_version=7 does not exist yet for GBR.

Why

Until now the UK hourly wage type and daily schedule were hidden from Partners API (remote_api) consumers, while the Remote product already had them. Partners could not onboard hourly UK employees. The backend change ships this as a new schema version (v7) because it is breaking for that surface.

What changed

Toggle details
  • example/src/flows/Onboarding/jsonSchemaVersions.ts: GBR contract_details 6 to 7.
  • GBR schema changelog and the version matrix document v7, with a migration snippet.
  • v7 adds wage_type, hourly_gross_salary, schedule_type and daily_schedule (replacing the plain work_hours_per_week). annual_gross_salary is only required when wage_type is salary.
  • The backend also ships contract_amendment GBR v3 in the same MR. The example app has no amendment demo, so it is not pinned or covered here.
  • Not public API; example app and docs only.

Screenshots

N/A

Related Resources

Testing

Checked against a local backend running the schema change:

  • GET /v1/countries/GBR/contract_details?json_schema_version=7 returns wage_type, hourly_gross_salary, schedule_type and daily_schedule. v6 returns none of them.

  • The example app requests v7 and renders the new "Employee schedule" section.

  • Not yet confirmed in the UI: the wage_type radio (Annual salary / Hourly pay) did not appear in the Salary section in my run. This needs a look before merge.

  • Tested against the example/ app in a browser

  • Feature flag: N/A

🤖 Generated with Claude Code


Note

Low Risk
Docs and example schema pin only; no runtime library changes, though the example will fail against backends that do not yet expose GBR v7.

Overview
Pins the example onboarding app to UK (GBR) contract details schema v7 and documents the upgrade for Partners API integrators.

The GBR changelog now describes v7: wage_type and hourly_gross_salary are exposed (no longer hidden from remote_api), the plain work_hours_per_week field is replaced by the daily schedule component (daily_schedule, schedule_type, work_hours_per_week, shift_pattern), and annual_gross_salary is required only when wage_type is salary. The country version matrix lists GBR at v7; jsonSchemaVersions.ts changes GBR contract_details from 6 → 7. Integrators on v6 or earlier are unchanged until they bump their pin.

Merge is intended after the backend ships json_schema_version=7 for GBR.

Reviewed by Cursor Bugbot for commit f61b507. Bugbot is set up for automated code reviews on this repo. Configure here.

Pin the United Kingdom to contract_details v7 in the example app and
document v7 in the GBR schema changelog and the version matrix. v7 stops
hiding wage_type and the daily schedule from Partners API consumers.

Depends on the Tiger change shipping first (tiger!100534).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Deploy preview for remote-flows ready!

Project:remote-flows
Status: ✅  Deploy successful!
Preview URL:https://remote-flows-cnwk3rdze-remotecom.vercel.app
Latest Commit:f61b507

Deployed with vercel-action

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Deploy preview for adp-cost-calculator ready!

Project:adp-cost-calculator
Status: ✅  Deploy successful!
Preview URL:https://adp-cost-calculator-q22v1n0ge-remotecom.vercel.app
Latest Commit:f61b507

Deployed with vercel-action

@gabrielseco
gabrielseco marked this pull request as ready for review October 14, 2026 16:03
@github-actions

Copy link
Copy Markdown
Contributor

📊 Coverage Report

✅ Coverage increased! 🎉

Metric Current Previous Change Status
Lines 89.59% 89.58% +0.02% 🟢
Statements 89.47% 89.45% +0.02% 🟢
Functions 88.48% 88.48% 0% ⚪
Branches 81.24% 81.21% +0.02% 🟢

Detailed Breakdown

Lines Coverage
  • Covered: 5397 / 6024
  • Coverage: 89.59%
  • Change: +0.02% (1 lines)
Statements Coverage
  • Covered: 5462 / 6105
  • Coverage: 89.47%
  • Change: +0.02% (1 statements)
Functions Coverage
  • Covered: 1428 / 1614
  • Coverage: 88.48%
  • Change: 0% (0 functions)
Branches Coverage
  • Covered: 3351 / 4125
  • Coverage: 81.24%
  • Change: +0.02% (1 branches)

✅ Coverage check passed

@gabrielseco
gabrielseco merged commit 7cbbced into main Oct 14, 2026
12 checks passed
@gabrielseco
gabrielseco deleted the chore/bump-gbr-contract-details-v7 branch October 14, 2026 16:38
@gabrielseco gabrielseco mentioned this pull request Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants