Repository navigation
ci(schema-canary): trigger PR runs on lockfile changes only - #1569
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
Contributor
|
Deploy preview for adp-cost-calculator ready!
Deployed with vercel-action |
Contributor
📊 Coverage Report✅ Coverage increased! 🎉
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
jordividaller
approved these changes
Oct 15, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The schema canary no longer runs on PRs that only edit
package.json. It runs when the rootpackage-lock.jsonchanges.Why
The canary exists to catch dependency changes that alter the generated schemas.
package.jsonalso changes for scripts, metadata and other edits that don't touch dependencies, which triggered the canary for nothing. The lockfile only changes when resolved dependencies change.What changed
Toggle details
package.jsonfrom thepull_request.pathsfilter in.github/workflows/schema-canary.yml. The barepackage-lock.jsonentry only matches the repo-root lockfile, notexample/package-lock.json.package.jsonalways comes with a lockfile change (CI installs withnpm ci), so the canary still runs for it.workflow_dispatchor pushes tomain.Screenshots
N/A
Related Resources
N/A
Testing
example/app in a browser: N/A🤖 Generated with Claude Code
Note
Low Risk
CI path-filter tweak only; no application or schema logic changes.
Overview
Narrows when the Schema Canary workflow runs on pull requests by removing
package.jsonfrom thepull_request.pathsfilter in.github/workflows/schema-canary.yml.PRs that only change
package.json(scripts, metadata, etc.) will no longer trigger the canary; rootpackage-lock.jsonchanges still do, so dependency resolution updates remain covered. Scheduled runs, manual dispatch, and pushes tomainare unchanged.Reviewed by Cursor Bugbot for commit 2bbfbe4. Bugbot is set up for automated code reviews on this repo. Configure here.