Skip to content

ci(schema-canary): trigger PR runs on lockfile changes only - #1569

Merged
gabrielseco merged 3 commits into
mainfrom
ci/schema-canary-lockfile-only
Oct 15, 2026
Merged

gabrielseco merged 3 commits into
mainfrom
ci/schema-canary-lockfile-only

Conversation

@gabrielseco

@gabrielseco gabrielseco commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

The schema canary no longer runs on PRs that only edit package.json. It runs when the root package-lock.json changes.

Why

The canary exists to catch dependency changes that alter the generated schemas. package.json also changes for scripts, metadata and other edits that don't touch dependencies, which triggered the canary for nothing. The lockfile only changes when resolved dependencies change.

What changed

Toggle details
  • Removed package.json from the pull_request.paths filter in .github/workflows/schema-canary.yml. The bare package-lock.json entry only matches the repo-root lockfile, not example/package-lock.json.
  • A dependency range edit in package.json always comes with a lockfile change (CI installs with npm ci), so the canary still runs for it.
  • No effect on the nightly schedule, workflow_dispatch or pushes to main.

Screenshots

N/A

Related Resources

N/A

Testing

  • Not testable locally. This PR itself touches neither the lockfile nor the other listed paths, so the canary should not run here. Seen in the checks list.
  • Tested against the example/ app in a browser: N/A
  • Feature flag: N/A

🤖 Generated with Claude Code


Note

Low Risk
CI path-filter tweak only; no application or schema logic changes.

Overview
Narrows when the Schema Canary workflow runs on pull requests by removing package.json from the pull_request.paths filter in .github/workflows/schema-canary.yml.

PRs that only change package.json (scripts, metadata, etc.) will no longer trigger the canary; root package-lock.json changes still do, so dependency resolution updates remain covered. Scheduled runs, manual dispatch, and pushes to main are unchanged.

Reviewed by Cursor Bugbot for commit 2bbfbe4. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Deploy preview for remote-flows ready!

Project:remote-flows
Status: ✅  Deploy successful!
Preview URL:https://remote-flows-eiuggdhwe-remotecom.vercel.app
Latest Commit:2bbfbe4

Deployed with vercel-action

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Deploy preview for adp-cost-calculator ready!

Project:adp-cost-calculator
Status: ✅  Deploy successful!
Preview URL:https://adp-cost-calculator-lpna4z4pd-remotecom.vercel.app
Latest Commit:2bbfbe4

Deployed with vercel-action

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

📊 Coverage Report

✅ Coverage increased! 🎉

Metric Current Previous Change Status
Lines 89.61% 89.58% +0.03% 🟢
Statements 89.48% 89.45% +0.03% 🟢
Functions 88.48% 88.48% 0% ⚪
Branches 81.26% 81.24% +0.02% 🟢

Detailed Breakdown

Lines Coverage
  • Covered: 5398 / 6024
  • Coverage: 89.61%
  • Change: +0.03% (2 lines)
Statements Coverage
  • Covered: 5463 / 6105
  • Coverage: 89.48%
  • Change: +0.03% (2 statements)
Functions Coverage
  • Covered: 1428 / 1614
  • Coverage: 88.48%
  • Change: 0% (0 functions)
Branches Coverage
  • Covered: 3352 / 4125
  • Coverage: 81.26%
  • Change: +0.02% (1 branches)

✅ Coverage check passed

@gabrielseco
gabrielseco merged commit e6a7b41 into main Oct 15, 2026
16 checks passed
@gabrielseco
gabrielseco deleted the ci/schema-canary-lockfile-only branch October 15, 2026 13:37
@gabrielseco gabrielseco mentioned this pull request Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants