Repository navigation
ci(schema-canary): only check the countries whose pin changed on PRs - #1559
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
|
Deploy preview for adp-cost-calculator ready!
Deployed with vercel-action |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
Contributor
📊 Coverage Report⚪ Coverage unchanged
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
jordividaller
approved these changes
Oct 15, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On a pull request, the schema canary now only checks the countries whose
contract_detailspin changed, instead of every EOR country.Why
What changed
Toggle details
scripts/schema-canary/changed-countries.ts: comparesjsonSchemaVersions.tsonHEAD^1(the base in the PR merge commit) withHEADand prints the countries whose pin changed,all, ornone. It printsallwhenever any other file changed, so edits to the canary, the form-building code orpackage.jsonstill run every country.schema-canary.ts:--countrynow accepts a comma-separated list.schema-canary.yml: the PR job fetches 2 commits, runs the picker, and passes the result to--country; withnone(for example a comment-only edit) the canary step is skipped.mainand nightly canary still check every country.Screenshots
N/A
Related Resources
Testing
changed-countries.test.tscovers parsing, a single and multiple changed pins, no change, and a newly pinned country.all, since it touches the canary files).🤖 Generated with Claude Code
Note
Low Risk
CI-only scope narrowing for PR jobs with a safe fallback to the full canary when non-pin files change; no runtime or public API impact.
Overview
PR schema canary runs only countries whose
contract_detailspin changed, instead of every EOR country—cutting PR runtime and unrelated sandbox flakes.A new
scripts/schema-canary/changed-countries.tscomparesjsonSchemaVersions.tsbetweenHEAD^1andHEADand prints a comma-separated country list,all(if any non-versions file changed or versions didn’t change), ornone. The PR workflow checks out two commits, runs that picker, skips the canary when output isnone, and passes the scope intonpm run schema-canary.schema-canary.tsnow treats--countryas a comma-separated list when filtering sandbox countries. Main and nightly jobs are unchanged (still full runs). Unit tests cover pin parsing and diff detection.Reviewed by Cursor Bugbot for commit 5188322. Bugbot is set up for automated code reviews on this repo. Configure here.