[gabrielseco]

Summary

Extends the contract details schema canary to submit filled values for every country and check the employment saved them unchanged.

Why

• A schema that builds isn't enough: it also has to submit, and the backend has to store what we sent.
• The read-back already found a real bug (GBR's overtime_eligible was dropped after save; Tiger has since fixed it).
• Split out of feat(scripts): add a contract details schema canary #1481 so the build/validate canary and the submit check can be reviewed separately.

What changed

Toggle details

Adds a submit check after pinned and latest: fills the pinned schema (scripts/fill-schema.ts plus per-country seeds), runs it through the SDK's build, validation, money conversion and parsing, sends the flow's PATCH /v1/employments/{id}, then reads the employment back. Fails the run on any value saved differently or not at all. Skipped when the pinned schema fails to build.

Read-back exceptions are narrow:

• Forced values (const equal to default, via checkFieldHasForcedValue) are skipped only when missing.
• KNOWN_UNSAVED_FIELDS lists per-country fields the backend drops. It's empty now that Tiger saves GBR overtime_eligible again. An entry fails once the value is saved again, so it gets removed.

CONTRACT_DETAILS_SEEDS moves to scripts/contract-details-seeds.ts, shared with seed-onboarding (adds a FRA seed). vitest.config.ts also picks up scripts/**/*.test.tsx.

Also adds the submit check to the PR canary job from #1493.

Screenshots

N/A

Related Resources

• Stack: refactor(headless-form): share the form build and validation outside React #1480 → feat(scripts): add a contract details schema canary #1481 → ci(schema-canary): run the contract details canary nightly and on PRs #1493 → this PR → feat(e2e): re-submit each country's contract details in the browser #1484

Testing

• Tested against the example/ app in a browser: N/A, this is a script.

• Feature flag: N/A

• Unit tests (MSW): scripts/schema-canary/submit-contract-details.test.ts, plus the submit cases in lib.test.ts.

• Locally: npm run schema-canary -- --country=FRA (needs .env.sandbox). All 92 countries pass pinned and submit against sandbox.

🤖 Generated with Claude Code

---

Note

Medium Risk
New sandbox PATCH/GET integration in CI can fail on backend persistence mismatches; logic is test-heavy and gated on pinned build success, but it exercises live employment APIs with secrets.

Overview
Adds a third submit check to the contract-details schema canary: after pinned/latest build validation, it auto-fills the pinned schema (shared CONTRACT_DETAILS_SEEDS, deterministic seedFor per country), runs the same headless-form build/validation/parsing as Onboarding, PATCHes sandbox employments, and GETs them back to assert saved contract_details match what was sent. Submit is skipped when pinned build fails; forced-only-missing fields and empty KNOWN_UNSAVED_FIELDS allow narrow read-back exceptions.

PR CI now runs --checks=pinned,submit (workflow path filter includes the new seeds file). Seeds move to scripts/contract-details-seeds.ts (adds FRA) for reuse by seed-onboarding. Unit coverage lives in submit-contract-details.test.ts and updated lib.test.ts; Vitest picks up scripts/**/*.test.tsx.

^{Reviewed by Cursor Bugbot for commit cf57420. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

Deploy preview for adp-cost-calculator ready!

Project:	adp-cost-calculator
Status:	✅  Deploy successful!
Preview URL:	https://adp-cost-calculator-inqxbdfn4-remotecom.vercel.app
Latest Commit:	cf57420

Deployed with vercel-action

[github-actions]

Deploy preview for remote-flows ready!

Project:	remote-flows
Status:	✅  Deploy successful!
Preview URL:	https://remote-flows-inq7w212s-remotecom.vercel.app
Latest Commit:	cf57420

Deployed with vercel-action

[github-actions]

📊 Coverage Report

⚪ Coverage unchanged

Metric	Current	Previous	Change	Status
Lines	89.58%	89.58%	0%	⚪
Statements	89.46%	89.46%	0%	⚪
Functions	88.47%	88.47%	0%	⚪
Branches	81.21%	81.21%	0%	⚪

Detailed Breakdown

Lines Coverage

• Covered: 5393 / 6020
• Coverage: 89.58%
• Change: 0% (0 lines)

Statements Coverage

• Covered: 5458 / 6101
• Coverage: 89.46%
• Change: 0% (0 statements)

Functions Coverage

• Covered: 1427 / 1613
• Coverage: 88.47%
• Change: 0% (0 functions)

Branches Coverage

• Covered: 3345 / 4119
• Coverage: 81.21%
• Change: 0% (0 branches)

✅ Coverage check passed

[cursor]

Stale Bugbot comment from a previous run.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit d3e8076. Configure here.}