Repository navigation
chore(ci): run PR checks on stacked PRs too - #1355
Merged
Merged
Conversation
pr.yml, pr-title.yml, and size-check.yml only triggered on pull_request when the base branch was main/release/*. A stacked PR (base = another feature branch, e.g. #1347's base of e2e-germany-onboarding) silently skipped lint, tests, build, size check, and title check entirely. Drop the branches: filter so these workflows run for a PR against any base branch. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
gabrielseco
changed the title
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
Contributor
|
Deploy preview for adp-cost-calculator ready!
Deployed with vercel-action |
Contributor
📊 Coverage Report⚪ Coverage unchanged
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
jordividaller
approved these changes
Sep 22, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI checks (lint, tests, build, bundle-size, PR-title) were skipping entirely on PRs whose base branch isn't
main/release/*— including stacked PRs like #1347, which targets a feature branch. Now they run for a PR against any base branch.Why
Stacked PRs (a PR whose base is another feature branch, not
main) are a normal part of this repo's workflow, butpr.yml,pr-title.yml, andsize-check.ymlall filteredon.pull_request.branchesto[main, release/*]. A PR targeting anything else got zero required checks — no lint, no type-check, no tests, no build, no size check, no conventional-commit title enforcement — until it was eventually retargeted atmain.What changed
Toggle details
.github/workflows/pr.yml: dropped thebranches: [main, release/*]filter onpull_request, so lint/format, type-check, build/exports, tests+coverage, example-app checks, and e2e all run regardless of base branch..github/workflows/pr-title.yml: same — conventional-commit title check now runs on stacked PRs too..github/workflows/size-check.yml: same,pathsfilter unchanged.No changes to
ci-main.yml(push-to-main pipeline) or anything path/schedule-triggered — those were already unaffected by base branch.Does not touch
src/index.tsxor any public API — CI config only.Screenshots
N/A
Related Resources
e2e-germany-onboarding, notmain)Testing
example/app in a browser — N/A, no app code changedNote
Low Risk
CI-only trigger broadening; no application code or runtime behavior changes, with slightly more Actions usage on non-main-base PRs.
Overview
PR checks now run for pull requests against any base branch, not only when the target is
mainorrelease/*.Three workflows drop the
on.pull_request.branchesfilter:pr.yml(lint, type-check, build, tests, coverage, example app, e2e, previews),pr-title.yml(conventional-commit title; release-branch head ref skip unchanged), andsize-check.yml(path filters for bundle-related files unchanged). Stacked PRs targeting feature branches get the same CI gates before they are retargeted to `main.Reviewed by Cursor Bugbot for commit 07f4bbc. Bugbot is set up for automated code reviews on this repo. Configure here.