Repository navigation
chore(ci): carry the 3.x dependency cleanup into 4.0 - #222
Merged
Merged
Conversation
#217 removed composer.lock and hardened the workflows on 3.x. This branch still carries all of it, so the file and the findings would return the moment 4.0 merges. Same reasoning as #217: consumers resolve their own dependencies, the dist tarball already excluded the lock via export-ignore, and CI installs with `composer update`. Verified the 4.0 tree resolves without it at the declared floor: `config.platform.php` 8.3, 193 installs, no conflict. The 8.4 requirement that broke the composer updater on 3.x came from the stale lock, not from the package. Also adds the daily docs reconcile from #221, since a GITHUB_TOKEN merge does not trigger `on: push`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targets
feat/4.0(the branch behind draft #216), not4.x. Without this, everything #217 fixed comes back when 4.0 merges.Why this branch and not 4.x
4.xhas zero commits of its own; it is a strict ancestor of3.xand is 16 commits behind it. All the real 4.0 work lives onfeat/4.0, which is 132 commits ahead of3.x. Merging3.xintofeat/4.0conflicts on exactly one file,composer.lock, a delete/modify. Deleting it here removes that conflict rather than leaving it for whoever merges 4.0.What comes back without this
feat/4.0currently carries:composer.lock, tracked, plus itsexport-ignoreline.dependabot.ymlwith noapplies-to, so security updates arrive one PR per advisory.Verification
The 4.0 dependency tree resolves without the lock at the declared floor:
No conflict. This matters because the PHP 8.4 requirement that silently broke the composer updater on 3.x came from the stale lock, not from the package:
"php": "^8.3"incomposer.jsonis accurate and stays unchanged.zizmor --no-online-auditsreports 0 findings across.github/workflowson this branch, down from 8.Also included
The daily docs reconcile from #221. A merge performed with
GITHUB_TOKENdoes not triggeron: push; three PRs merged that way on 3.x today produced zero check runs between them. Including it here keeps 4.0 from shipping with the same gap.Review note: #221 should land on 3.x first. If it changes shape in review, this branch should track it.