[v26.1.x] compaction: fix min.compaction.lag.ms comparision for future timestamps - #31459
Merged
WillemKauf merged 2 commits intoAug 6, 2026
Merged
Conversation
A segment's retention timestamp may be ahead of the local clock, which compares unfavourably against a min_lag_ms of 0, leaving the segment uncompactible until the clock catches up on a topic that never configured a lag at all. Kafka skips the timestamp check entirely when the lag is unset (see `LogCleanerManager::cleanableOffsets`), so do the same here. (cherry picked from commit 9645653)
The same defect as the preceding commit, in the L1 compaction source. Skip the timestamp check entirely when the lag is unset, as Kafka does. A negative lag is treated as unset too, mirroring Kafka's `Math.max(compactionLagMs, 0)`. (cherry picked from commit 551cc75)
WillemKauf
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #31442