[v25.3.x] rpk/connect: don't cap version segments at two digits - #31451
Merged
r-vasquez merged 1 commit intoAug 5, 2026
Merged
Conversation
install validated --connect-version against
`^v?\d{1,2}\.\d{1,2}\.\d{1,2}`. The two-digit cap on each segment
rejected every Redpanda Connect release since 4.100.0 before the plugin
manifest was ever consulted.
Segments are now unbounded in width, and the pattern is anchored at both
ends so trailing garbage fails validation up front rather than at
download time. The optional [-+] suffix group preserves prereleases like
4.102.0-rc1, which the previous unanchored pattern accepted and forwarded
to the manifest.
The ai, check and k8s plugin validators carry a copy of the same regex
and are deliberately left untouched here.
Covered by a new TestValidateVersion; the package had no test file
previously.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
(cherry picked from commit 4f03977)
vbotbuildovich
requested review from
a team,
kbatuigas and
r-vasquez
as code owners
August 5, 2026 19:56
r-vasquez
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #31438
Conflict details
No content conflicts.
4f03977837auto-merged ontov25.3.xwith onlycontext shifts in
src/go/rpk/pkg/cli/connect/install.goandsrc/go/rpk/pkg/cli/connect/BUILD.Skipped commit
7d6f0758de("Merge remote-tracking branch 'origin/dev' intorpk-uncap-plugin-version-segments"): a merge of
devinto the PR branch, notauthored PR content. Its diff against second parent (
dev) is exactly thethree files already delivered by
4f03977837; its diff against first parent(the PR commit) is unrelated
src/v/cloud_topics/work picked up fromdev.Cherry-picking it with
-m 1would have imported that unrelated cloud_topicschange onto the release branch, so it was skipped. No PR code is dropped: the
backported tree contains the full change (regex fix, doc comment, new
install_test.go, and thego_testtarget inBUILD).Note on divergence from
devv25.3.xstill has the olderconnectRepoClient/getPluginURLimplementationin this package, whereas
devhas refactored it toplugin.RepoClient. Thatrefactor is out of scope for this backport and was intentionally not carried
over; the version-validation fix is self-contained in
validateVersionandapplies to both shapes unchanged.
Verification not performed
go test ./pkg/cli/connect/ -run TestValidateVersioncould not be executed inthe backport sandbox (command not permitted). The new test is carried over
verbatim from the source commit and is expected to pass; CI on the backport PR
will confirm.
Fixes: #31450,