[v26.1.x] rpk/connect: don't cap version segments at two digits - #31449
Merged
r-vasquez merged 1 commit intoAug 5, 2026
Merged
Conversation
install validated --connect-version against
`^v?\d{1,2}\.\d{1,2}\.\d{1,2}`. The two-digit cap on each segment
rejected every Redpanda Connect release since 4.100.0 before the plugin
manifest was ever consulted.
Segments are now unbounded in width, and the pattern is anchored at both
ends so trailing garbage fails validation up front rather than at
download time. The optional [-+] suffix group preserves prereleases like
4.102.0-rc1, which the previous unanchored pattern accepted and forwarded
to the manifest.
The ai, check and k8s plugin validators carry a copy of the same regex
and are deliberately left untouched here.
Covered by a new TestValidateVersion; the package had no test file
previously.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
(cherry picked from commit 4f03977)
r-vasquez
approved these changes
Aug 5, 2026
r-vasquez
enabled auto-merge
August 5, 2026 23:18
Collaborator
Author
CI test resultstest results on build#88279
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #31438
Note on the PR's second commit
The PR lists two commits.
7d6f0758deis aMerge remote-tracking branch 'origin/dev'sync merge, not PR content, and it is intentionally notcherry-picked:
git show 7d6f0758de) is empty, so it is not an evilmerge — it carries no conflict-resolution changes of its own.
git diff 4f03977837 7d6f0758de -- src/go/rpk/pkg/cli/connect/is empty,so it contributes nothing to the files this PR touches.
All of the PR's content is in
4f03977837, and the three files it changesmatch the PR's file list exactly (
src/go/rpk/pkg/cli/connect/BUILD+8/-1,install.go+6/-3,install_test.go+27/-0).Conflict details
None —
4f03977837applied cleanly ontov26.1.x.@com_github_stretchr_testify//require(the newgo_testtarget's only dep)is already available on
v26.1.x:github.com/stretchr/testify v1.11.1is insrc/go/rpk/go.modand the label is used by existing rpk BUILD files.The new
TestValidateVersionwas not executed locally; CI covers it.Fixes: #31448,