Skip to content

[v26.2.x] ct/l0: preserve the produce-time record crc on the read path - #31389

Merged
andrwng merged 1 commit into
redpanda-data:v26.2.xfrom
vbotbuildovich:backport-pr-31375-v26.2.x-781
Jul 31, 2026
Merged

[v26.2.x] ct/l0: preserve the produce-time record crc on the read path#31389
andrwng merged 1 commit into
redpanda-data:v26.2.xfrom
vbotbuildovich:backport-pr-31375-v26.2.x-781

Conversation

@vbotbuildovich

Copy link
Copy Markdown
Collaborator

Backport of PR #31375

Previously, when L0 materialized record batches from the payloads in
object storage, we were resetting the record-batch crc and rederiving
it from the materialized payload data, rather than using the crc in
object storage that were written at produce time. This meant that we
wouldn't have detected a corrupted bit at rest when served from object
storage.

Updates the record-batch materialization code to use the record-batch
crc and only recompute the header_crc (needed since neither the
placeholder nor the object storage batch have the full
materialized-batch header_crc with correct offset and size).

(cherry picked from commit 4be7193)
@vbotbuildovich vbotbuildovich added this to the v26.2.x-next milestone Jul 31, 2026
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Jul 31, 2026
@vbotbuildovich
vbotbuildovich requested a review from andrwng July 31, 2026 18:01
@vbotbuildovich

Copy link
Copy Markdown
Collaborator Author

CI test results

test results on build#88044
test_status test_class test_method test_arguments test_kind job_url passed reason test_history
FLAKY(PASS) NodeWiseRecoveryTest test_recovery_local_data_missing {"wait_for_final_manifest_uploads": false} integration https://buildkite.com/redpanda/redpanda/builds/88044#019fb964-10dc-4833-9fb8-889c726b9c6d 10/11 Test PASSES after retries.No significant increase in flaky rate(baseline=0.0598, p0=1.0000, reject_threshold=0.0100. adj_baseline=0.1690, p1=0.1571, trust_threshold=0.5000) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=NodeWiseRecoveryTest&test_method=test_recovery_local_data_missing

@andrwng
andrwng merged commit b051363 into redpanda-data:v26.2.x Jul 31, 2026
18 checks passed
@tyson-redpanda tyson-redpanda modified the milestones: v26.2.x-next, v26.2.2 Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build area/redpanda kind/backport PRs targeting a stable branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants