[v26.1.x] [CORE-16282] json: make the schema walk keyword-aware - #30922
Merged
mnajda-redpanda merged 1 commit intoJun 25, 2026
Merged
Conversation
The bundled-schema walk descended into every nested object, so a key matching a schema keyword (e.g. a property named "id" under draft-04, or "$id"/"$ref" elsewhere) was misread as that keyword and the schema was rejected. Classify keywords by where subschemas appear and only descend into genuine subschema positions, gated by dialect, so keys under "properties", "$defs", etc. are treated as names. (cherry picked from commit 4ea8f6e)
mnajda-redpanda
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #30865