[v26.1.x] kafka/protocol: bound parse_tags by remaining message bytes - #30196
Merged
rockwotj merged 1 commit intoApr 16, 2026
Merged
Conversation
parse_tags now takes a max_bytes parameter and checks two limits before allocating each tagged field: 1. A cumulative budget check: the field length cannot exceed the bytes remaining in the message. Both callers already have a validated total message size (connection_context has sz from parse_size; transport has bytes_remaining), so this bound is derived from actual data rather than a hardcoded constant. 2. A per-field cap of 128 KiB, retained as a sanity limit on any single field. All exceptions are now net::parsing_exception subclasses so the server classifies them as parse-error disconnects rather than unexpected errors. (cherry picked from commit 17b5168)
rockwotj
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #30191