fix: unwrap constructors to primitives in type mapping - #3174
Merged
Merged
Conversation
- Uses zIncrBy which actually returns a DoubleReply - Verifies RESP_TYPES.DOUBLE maps to Number correctly - Replaces previous test that incorrectly used hello() command
Use existing docker infra for testing, add DOUBLE test
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
nkaradzhov
self-requested a review
February 10, 2026 13:18
nkaradzhov
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"This PR supersedes my previous PR #3150. It includes the updates provided by @nkaradzhov and ensures the type mapping correctly handles constructor inference. Re-opening from master to provide a clean commit history."