PHP Fatal error: Cannot declare interface PhpParser\NodeVisitor, because the name is already in use in vendor/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeVisitor.php on line 6

[ostrolucky]

Bug Report

Subject	Details
Rector version	2.1.0

Minimal PHP Code Causing Issue

It seems some of the projects do not have a proper nikic/php-parser dependency declared and it causes declarations to be incompatible. See this pipeline failing https://github.com/ostrolucky/rector-rules/actions/runs/16004559868/job/45147964072

Expected Behaviour

No parse error

[samsonasik]

You can include rector preload.phpon phpunit bootstrap, see example on

https://github.com/cakephp/upgrade/blob/3f199706cb7560d4e1e599371c239f6df9d02ee0/tests/bootstrap.php#L14

[TomasVotruba]

@ostrolucky It's a scoped package, like PHPStan, so php-parser is shipped with it's /vendor.
Looking at yjour repository, it's pretty simple 🤔 I wonder if PCOV might be causing the issue there.

Be sure to use only Rector 2.1, because 1.0 is not maintained anymore and there were BC breaks.

Could you try running CI matrix with different PHP versions? + without other deps listed in composer.json.
It will be some weird glitch IMO

[ostrolucky]

@samsonasik didn't work, reopen pls ostrolucky/rector-rules@2845cc5

@TomasVotruba it seems it starts happening since php 8.3 https://github.com/ostrolucky/rector-rules/actions/runs/16005375800

[ostrolucky]

It seems difference between 8.2 (highest) and 8.3 (highest) is just phpunit (11.x vs 12.x)

[samsonasik]

@ostrolucky I will look into that on php 8.3+ locally

[samsonasik]

In phpunit 12, It seems phpunit too early load vendor/autoload.php even not defined, see these 2 lines:

• https://github.com/sebastianbergmann/phpunit/blob/7c2e0781d70a2455041ef7e26c46b37bd558b3df/phpunit#L46
• https://github.com/sebastianbergmann/phpunit/blob/7c2e0781d70a2455041ef7e26c46b37bd558b3df/phpunit#L72

[samsonasik]

This line:

rector/src/Testing/PHPUnit/AbstractLazyTestCase.php

Line 55 in 9d7b184

require_once __DIR__ . '/../../../preload.php';

may need to be changed to require vendor/scoper-autoload.php'

        if (\file_exists(__DIR__ . '/../../../preload.php')) {
            if (\file_exists(__DIR__ . '/../../../vendor')) {
-                require_once __DIR__ . '/../../../preload.php';
+                require_once __DIR__ . '/../../../vendor/scoper-autoload.php';

I will check on possible issue on that ...

[samsonasik]

I am looking at it at PR:

• [Testing] Modify autoload on AbstractLazyTestCase to only use vendor/scoper-autoload.php when it exists rector-src#7039

[samsonasik]

@ostrolucky I got it, you need to add:

        "files": [
            "vendor/rector/rector/preload.php"
        ]

under autoload-dev, I created PR to your repository:

• chore!: handle conflict phpunit 12+ conflict preload with rector ostrolucky/rector-rules#44

[tucksaun]

@ostrolucky I got it, you need to add:

    "files": [
        "vendor/rector/rector/preload.php"
    ]

under autoload-dev, I created PR to your repository:

* [chore!: handle conflict phpunit 12+ conflict preload with rector ostrolucky/rector-rules#44](https://github.com/ostrolucky/rector-rules/pull/44)

We had the same issue on a project I work on, so thank you for the fix.

This brings a question to me though: should this be added as a note in the documentation about "Writing Tests For Custom Rule" ?