Repository navigation
Attach event per react container root, rather than on the document #2043
Description
Activity
@chenglou That would help our situation with the editor a bit, yes. But what's more important for Atom I think is the ability to integrate React with HTML custom elements without requiring the use of the shadow DOM. Seems like #1711 would help that, and it seems like this idea might be necessary to achieve that as well?
@nathansobo Can you clarify what you mean, "without requiring the use of the shadow DOM"? I'm a bit uninformed about how HTML custom elements work right now.
@syranide I don't see why we should close issues just because there's a PR open – what if we don't go with that particular implementation? We may still want to make the same fix.
Just FYI, this effort may get new life due to: testing-library/react-testing-library#35
If I can't push this along myself, I'll try to encourage others to do so. Thanks!
Reacted by Brandon Dail, Yury Karalkou, Nicky McCurdy, Ed Moore, Ian Sutherland, Michaël De Boey, Paul Hammond, Niek Kruse, cybai (Haku), mseddon and 6 more@trueadm has been working on this. Not yet 100% sure but it's likely we'll do this change in a major (right now it's behind a flag).
Reacted by Kent C. Dodds, Michelle Tilley, Rafael de Oleza, Ruben Barilani, Adnane Tellou, Anton, Bern and Kevin KippReacted by Michelle Tilley- Reacted by Kent C. Dodds and PupoSDCReacted by ryenus, Sarthak Batra, James, Dave Houlbrooke, dominicfraser and PupoSDC
@nathansobo will that help your event perf issues a bit? I'm not familiar with atom's plugin infrastructure, But this'll help if you have
<Editor/><Plugin1/>(tworenderComponents). Doesn't help if you have<Editor><Plugin1/></Editor>though, but I have some ideas to optimize events a bit more.This is nonetheless an ok idea, I think.
@spicyj