Repository navigation
Conversation
meta-cla
Bot
added
the
CLA Signed
…e bundle config (#54258) Summary: ## Summary It associates `RCTPackagerConnection` (previously singleton) with the `RCTDevSettings` instance, which has access to the `RCTBundleManager`, which contains the specified configuration object. The connection is now established in the `RCTDevSettings initialize` method, called after the bundle manager is set by invoking the new `startWithBundleManager` method on the `RCTPackagerConnection`. ## Changelog: [IOS][BREAKING] - Make `RCTPackagerConnection` instance of the `RCTDevSettings` and use bundle config. Reviewed By: vzaidman Differential Revision: D85247267
Summary: The diff exposes `addNotificationHandler` and `addRequestHandler` from `RCTDevSettings`. Previously, handlers were registered by accessing `RCTPackagerConnection` which is not a shared instance any more. Changelog: [GENERAL][ADDED] - Expose methods for registering packager connection handlers. Reviewed By: cipolleschi, huntie Differential Revision: D85766955
|
This pull request has been merged in d9842fd. |
Collaborator
|
This pull request was successfully merged by @coado in d9842fd When will my fix make it into a release? | How to file a pick request? |
douglowder
pushed a commit
to react-native-tvos/react-native-tvos
that referenced
this pull request
Nov 15, 2025
Summary: Pull Request resolved: react/react-native#54314 The diff exposes `addNotificationHandler` and `addRequestHandler` from `RCTDevSettings`. Previously, handlers were registered by accessing `RCTPackagerConnection` which is not a shared instance any more. Changelog: [GENERAL][ADDED] - Expose methods for registering packager connection handlers. Reviewed By: cipolleschi, huntie Differential Revision: D85766955 fbshipit-source-id: c1373d231ef82fcb2f156a7dcb6a9bf87071af87
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 27, 2025
Summary: I *think* this is to blame for issues with HMRClient::setup() not being called in release builds. Changelog: [General][Removed] Revert #54314 Differential Revision: D87982319
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differential Revision: D85766955
The diff exposes
addNotificationHandlerandaddRequestHandlerfromRCTDevSettings. Previously, handlers were registered by accessingRCTPackagerConnectionwhich is not a shared instance any more.Changelog:
[GENERAL][ADDED] - Expose methods for registering packager connection handlers.