Repository navigation
Fixes for AttributedString Comparison - #50147
Closed
NickGerleman wants to merge 1 commit into
Closed
NickGerleman wants to merge 1 commit into
NickGerleman wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71500246 |
Summary: Noticed a couple bugs here, around a crash from assertion internal to the caching map which hashes on the AttributedString, that may or may not be related. 1. We are missing `baseTextAttributes` for both hashing and equality (which is mostly innocuous, but still wrong) 2. We were not hashing or comparing `textAlignVertical` 3. For equality, we were comparing parent shadow view tag and metrics, but for hashing, we were hashing the whole ShadowView. I think microsoft#3 could cause issues, since we could see different hash despite equality, which could break invariants. Changelog: [Internal] Reviewed By: lunaleaps Differential Revision: D71500246
NickGerleman
force-pushed
the
export-D71500246
branch
from
March 19, 2025 22:38
3cd2b0d to
c44b0be
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71500246 |
Contributor
|
This pull request has been merged in 7136be2. |
Collaborator
|
This pull request was successfully merged by @NickGerleman in 7136be2 When will my fix make it into a release? | How to file a pick request? |
Merged
1 of 6 tasks
j0ntz
added a commit
to EdgeApp/edge-react-gui
that referenced
this pull request
Sep 28, 2026
Debug builds abort in the TextInput measure cache on the Buy scene. React Native 0.79.2 hashes an AttributedString::Fragment by its whole parent ShadowView (props, event emitter and state pointers), while equality compares only the tag and layout metrics. Two equal strings can then land in different buckets, and folly's F14 fallback set trips a debug-only FOLLY_SAFE_DCHECK when it finds the equal key by linear scan on a small cache. Backport the hash and equality changes from upstream react/react-native#50147 (in 0.80.0): hash the parent tag instead of the whole ShadowView, and include the base text attributes in both the AttributedString hash and equality. TextAttributes equality already covers textAlignVertical in 0.79.2, so that part of the upstream change is not needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Noticed a couple bugs here, around a crash from assertion internal to the caching map which hashes on the AttributedString, that may or may not be related.
baseTextAttributesfor both hashing and equality (which is mostly innocuous, but still wrong)textAlignVerticalI think #3 could cause issues, since we could see different hash despite equality, which could break invariants.
Changelog: [Internal]
Differential Revision: D71500246