Repository navigation
Update codegen to support namespaced types - #49950
j-piasecki wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70967809 |
|
This pull request was exported from Phabricator. Differential Revision: D70967809 |
5 similar comments
|
This pull request was exported from Phabricator. Differential Revision: D70967809 |
|
This pull request was exported from Phabricator. Differential Revision: D70967809 |
|
This pull request was exported from Phabricator. Differential Revision: D70967809 |
|
This pull request was exported from Phabricator. Differential Revision: D70967809 |
|
This pull request was exported from Phabricator. Differential Revision: D70967809 |
Summary: Pull Request resolved: #49950 Changelog: [GENERAL][CHANGED] - Changed `react-native-codegen` to support types under `CodegenTypes` namespace ## Summary Currently, codegen relies on deep importing types under `react-native/Libraries/Types/CodegenTypes` to be properly type-checked. Updating codegen to support types under a single namespace will enable us to provide a single import from the package with access to all relevant types. Reviewed By: huntie Differential Revision: D70967809
|
This pull request was exported from Phabricator. Differential Revision: D70967809 |
|
This pull request has been merged in 5349b7c. |
|
This pull request was successfully merged by @j-piasecki in 5349b7c When will my fix make it into a release? | How to file a pick request? |
3 participants
Summary:
Changelog: [GENERAL][CHANGED] - Changed
react-native-codegento support types underCodegenTypesnamespaceSummary
Currently, codegen relies on deep importing types under
react-native/Libraries/Types/CodegenTypesto be properly type-checked. Updating codegen to support types under a single namespace will enable us to provide a single import from the package with access to all relevant types.Differential Revision: D70967809