Skip to content

Fix anti-aliasing on older Android devices - #48749

Closed
jorge-cab wants to merge 1 commit into
react:mainfrom
jorge-cab:export-D68279400
Closed

jorge-cab wants to merge 1 commit into
react:mainfrom
jorge-cab:export-D68279400

Conversation

@jorge-cab

@jorge-cab jorge-cab commented Jan 16, 2025 •

Copy link
Copy Markdown
Contributor

On older Android versions clipping doesn't have anti-aliasing by default which means that clipping with no border will always make the background not have anti-aliasing.

This is fixed by default on new Background and Border drawables since rendering logic is separated

Moving the clipping logic so it only runs when we have a border.

#41226

Changelog: [Android] [Fixed] - Fixed anti-aliasing not showing on older Android versions

Summary:
On older Android versions clipping doesn't have anti-aliasing by default which means that clipping with no border will always make the background not have anti-aliasing. 

This is fixed by default on new Background and Border drawables since rendering logic is separated

Moving the clipping logic so it only runs when we have a border.

Differential Revision: D68279400
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 16, 2025
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D68279400

@react-native-bot

react-native-bot commented Jan 16, 2025 •

Copy link
Copy Markdown
Collaborator
Warnings
⚠️ 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against fcae46e

@javache

javache commented Apr 25, 2025

Copy link
Copy Markdown
Contributor

Merged as 6c6e0a9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants