Repository navigation
[RN][CI] Zip slices to preserve symlinks - #46387
Closed
cipolleschi wants to merge 1 commit into
Closed
cipolleschi wants to merge 1 commit into
cipolleschi wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
force-pushed
the
cipolleschi/fix-symlinks-main
branch
from
September 8, 2024 12:09
fe580aa to
fab59ef
Compare
cipolleschi
force-pushed
the
cipolleschi/fix-symlinks-main
branch
from
September 8, 2024 12:15
fab59ef to
b4603e1
Compare
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cipolleschi merged this pull request in d424c24. |
Collaborator
|
This pull request was successfully merged by @cipolleschi in d424c24 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When creating Hermes in CI, we build it for MacOS and Mac Catalyst as well.
The slices for these platforms requires symlinks to work properly.
The upload artifacts action on github, when applied to folders, follows the symlinks and copies the destination folder. The result is that Hermes for macOS and Catalyst does not work as expected.
This should fix #46213.
Changelog:
[Internal] - Build Hermes in CI properly
Test Plan:
Tested already in 0.75