Repository navigation
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50644900 |
Base commit: 0c7008f |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50644900 |
9 similar comments
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50644900 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50644900 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50644900 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50644900 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50644900 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50644900 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50644900 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50644900 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50644900 |
Summary: Changelog: [Internal] Having a static import of `ReactFabric` blocks from using `ReactNativeElement` class for Paper-only applications. Although DOM Node APIs are Fabric-only, the ability to use `instanceof ReactNativeElement` is a nice tool for gating purposes, which currently can't be used because of the static import. Differential Revision: D52784886 fbshipit-source-id: cf2685b3dfeca162d7a4e5e1aa303b0cfc194b11
…ompatible with previous Fabric implementation Summary: Changelog: [Internal] Currently, OSS versions ofReactFabric and ReactNativeRenderer artifacts are ~2 years behind the FB version. Fabric host components store internal instance in __internalInstanceHandle field, previously they have been storing it in the field with the same name, but with one underscore in prefix: https://www.internalfb.com/code/fbsource/[79c52d10beb6]/xplat/js/react-native-github/packages/react-native/Libraries/Renderer/implementations/ReactFabric-dev.js?lines=5151 Once these artifacts will be synced, the implementation will use __internalInstanceHandle field, so we can safely remove the branch with a single underscore prefix. Differential Revision: D52697886 fbshipit-source-id: ee5c3a60f8bf4251ba28897d58bd6ce9fc008c1a
…stance Summary: Changelog: [Internal] Manually patching public React renderers artifacts to include `isChildPublicInstance` method, which was added in react/react#27783. To identifly the required changes in code I've ran a diff for 2 commits: 1. The one with the changes 2. Its parent FB implementation were synced in D51816108. Differential Revision: D52697885 fbshipit-source-id: b8dfbc641899516c7c62bb79bd21fae1a1981a0c
Summary: Pull Request resolved: #41743 Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods. In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements. Differential Revision: D51536787 Reviewed By: rshest fbshipit-source-id: a6a64ef5f2cec6eb10881275929272ce02038c20
Summary: Pull Request resolved: #41744 Changelog: [Internal] With these changes: - DebuggingRegitry is responsible for listening to the events from React DevTools and - AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry - [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51603860 Reviewed By: sammy-SC fbshipit-source-id: 7ec87efc1ba07efe98cf9788560088653bb05856
…ents Summary: Changelog: [Internal] Differential Revision: https://internalfb.com/D51603861 fbshipit-source-id: c836f301b38831b3ecdd6170e3077ae8a09229e3
…eact DevTools (#41746) Summary: Pull Request resolved: #41746 Changelog: [Internal] Now using previously added `highlightElements` and `clearElementsHighlights` commands. [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times. All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51708053 Reviewed By: sammy-SC fbshipit-source-id: 97f85f7b236602da9bc1b7bacf6c347ce67faec8
Summary: Changelog: [Internal] Differential Revision: https://internalfb.com/D51708055 fbshipit-source-id: 8cf3e4a1cd39c45c7350a9a06b9eab70909559b5
Summary: Changelog: [Internal] Differential Revision: https://internalfb.com/D51708054 fbshipit-source-id: 33a2b89f1889963057593f3c4f296e3048a3c88c
Summary: Pull Request resolved: #41750 # Changelog: [ANDROID] [FIXED] - fixed unexpected resizing of ReactRootView for dev bundles in brownfield apps There was an android-only issue related to brownfield apps, when React Native root view is inside a modal and resizes it - #38024 Here is an explanation: #38024 (comment) Reviewed By: NickGerleman, motiz88 Differential Revision: D50644900 fbshipit-source-id: 277a19f3cf55e1113ce3522db4eae69274b28f7f
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50644900 |
Contributor
|
This pull request has been merged in 5d68c90. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[ANDROID] [FIXED] - fixed unexpected resizing of ReactRootView for dev bundles in brownfield apps
There was an android-only issue related to brownfield apps, when React Native root view is inside a modal and resizes it - #38024
Here is an explanation: #38024 (comment)
Differential Revision: D50644900