Repository navigation
Add errata "PercentAbsoluteOmitsPadding" (#1290) - #37376
Closed
NickGerleman wants to merge 2 commits into
Closed
NickGerleman wants to merge 2 commits into
NickGerleman wants to merge 2 commits into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45763574 |
Base commit: 40f816d |
NickGerleman
force-pushed
the
export-D45763574
branch
from
May 11, 2023 09:53
0960bfc to
2367dc3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45763574 |
NickGerleman
force-pushed
the
export-D45763574
branch
from
May 11, 2023 10:00
2367dc3 to
6d52bac
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45763574 |
Summary: Adds internal helpers to YGConfig to make bit manipulation more readable. We also expose `hasErrata()` to YGNode beacuse checking that will be a common pattern. We intentionally don't add mutating functions to the node, since current model is to inval a node on commiting whole config. This is not exposed via the C ABI. Differential Revision: D45765971 fbshipit-source-id: f8e6ad737d5693cf2036b73bd7a5fa30fc0419d4
Summary: Pull Request resolved: react#37376 X-link: react/yoga#1290 This change default-enables a bugfix to Yoga's handling of absolute-positioned children sized using percentages. Yoga previously measured percentage of the box without padding, where the W3C spec, and browser behavior verified by test, use the padding box instead. See react/yoga#850 for more details of the backing issue. I have so far left this behind a `YGExperimentalFeature`, because it will change the dimensions of existing views which use absolute percentages with parent padding. This change moves it from a `YGExperimentalFeature` to `YGErrata`. This means the conformant path is enabled by default, but users of `YGErrataClassic` and `YGErrataAll` will stay on the previous behavior. Right now the name is `PercentAbsoluteOmitsPadding` as something that tries to explain the issue in lay-terms and be a little less long than the old one, but I am open to other ideas. Reviewed By: yungsters Differential Revision: D45763574 fbshipit-source-id: a5e17e2efd5478a236cf585f2bf67c6b823539e3
NickGerleman
force-pushed
the
export-D45763574
branch
from
May 11, 2023 10:08
6d52bac to
73de067
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45763574 |
Contributor
|
Closing as planned changes internally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: react/yoga#1290
This change default-enables a bugfix to Yoga's handling of absolute-positioned children sized using percentages. Yoga previously measured percentage of the box without padding, where the W3C spec, and browser behavior verified by test, use the padding box instead. See react/yoga#850 for more details of the backing issue.
I have so far left this behind a
YGExperimentalFeature, because it will change the dimensions of existing views which use absolute percentages with parent padding.This change moves it from a
YGExperimentalFeaturetoYGErrata. This means the conformant path is enabled by default, but users ofYGErrataClassicandYGErrataAllwill stay on the previous behavior.Right now the name is
PercentAbsoluteOmitsPaddingas something that tries to explain the issue in lay-terms and be a little less long than the old one, but I am open to other ideas.Differential Revision: D45763574