Repository navigation
Conversation
…war, the Dreyfus affair on justice) Three event rows nominated on the owner's words "Yes, rows 1–3" (5 November 2026), in first-v1's shape: WordNet sense matches, Wikidata ids verified (Q14665, Q223085, Q173457), dated evidence checked on 2026-11-05, checksum stamped. Nothing is public until a reviewer accepts on /connections/:id. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#310 §6: the farce-v1 exemplar manifest, and what blocks seeding it
Draft until the seeder can take event subjects (see below). On the owner's words "Yes, rows 1–3" (5 November 2026).
What is in the branch
priv/exemplars/farce-v1.json, three rows infirst-v1's shape, checksum3b8ff07e…stamped (verified againstExamples.Manifest.checksum/1onfirst-v1):Every Wikidata id and URL was checked on 2026-11-05.
Dry run against v2 (read-only,
--dry-run, from this worktree, 5 Nov 00:5x UTC; nothing written, max assertion id 3902392 unchanged)Rows 2 and 3 are optimistic: a dry run makes no request, and the real mint goes through
SourceIdentity.Creators.classify/2, which returns{:permanent, :not_a_creator_kind}for anything that is not a human or an organisation, so both would be refusedsubject_not_mintableat seeding.Why, and the bounded fix this PR needs before it leaves draft
Examples.Manifestacceptseventsubjects andpredicate_endpoint_rulesallowentity:event → senseforillustrates, butExamples.Seedermints only throughCreators(persons, organisations).conceptbecause the Wikidata walk recognises events only for P31 inQ1656682 Q1190554 Q495307 Q752783(absorb/sources/wikidata.ex:721); its class is Q645883 military operation.Seeder.held_subject/2refuses any held concept (subject_held_as_concept).Fix, in this branch: (1) a general Wikidata mint for
event,workandartifactsubjects in the seeder, typed by the walk's ownentity_kind/2and required to equal the manifest's kind; (2) the event class list extended with the military-conflict classes (at least Q645883 military operation, Q198 war, Q178561 battle), with the M2 consequence stated; (3) a held concept whose storedwikidata_instance_ofnow maps to the manifest's kind is re-typed in the seeding transaction and the change recorded, instead of refused; (4) tests: classify fixtures for events, seeder dry-run and seed on these three rows, the existingfirst-v1behaviour unchanged. No migration, noconfig/*.exsormix.lockchange.Live steps after merge, each on the owner's typed yes, one at a time
Fast-forward deploy (no restart);
mix dd.exemplars.seed priv/exemplars/farce-v1.json --as internal-contributor@example.testfrom the serving checkout withDD_NO_OBAN=1(three Wikidata requests at Wikidata's own pace); the owner accepts each nomination on/connections/:idas the reviewer account; then the #310 §7 comparison batch.🤖 Generated with Claude Code