Repository navigation
#300 L2: Hitchens and Bierce dossiers as reviewed data files (nothing admitted) - #302
Conversation
Two sourced persona dossiers in the exact shape of voltaire/v8/profile.json, for the LP-1 roster (Voltaire, Hitchens, Bierce, k = 2): - hitchens/v1 (hitchens-whole-entry-v1): five short quotations from two in-copyright works (Slate 2003, Vanity Fair 2008), each source with a rights note; deceased evidence from LoC n84159549 and Wikidata Q49081. - bierce/v1 (bierce-whole-entry-v1): six entries from The Devil's Dictionary, Project Gutenberg #972 (public domain in the USA); the seat judges highlights only, since the Bierce-first lead rule already uses his text; deceased evidence from LoC n79100683 (1914?, "d. after Dec. 26, 1913") and Wikidata Q191050. One page of notes per dossier under docs/curation/personas, and a fixture-only shape test. Nothing is admitted, registered or activated, and no runtime code reads these files: the persona-by-slug seam is #298 Part C, and each lens is first a non-publishing comparison arm under #298 Part D. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reached
This review includes 1 billable file and costs up to $0.25.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 7 minutes for your next included review. View limit details
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Independent exact-head review of
|
| # | Confirmed |
|---|---|
| H1–H3 | Exact substrings of the Internet Archive capture 20031023010642, in both the framed page and the id_ raw capture. They sit in body ¶2, ¶7 and ¶8 respectively. The column has 8 body paragraphs, about 1,070 words, followed by the Oct. 21 correction. The paragraph openings in locators, the byline, "Posted Monday, October 20, 2003, at 1:04 PM PT", "Fighting Words" and the 2003 Microsoft copyright line are all on the capture. The current slate.com republication contains H1 and H2 and ends at ¶7 and the correction, so ¶8 and H3 are absent. That matches the edition note. |
| H4–H5 | Exact substrings of the Vanity Fair page, in the two paragraphs the locators name. The page shows "From the Magazine August 2008 Issue", the date July 2, 2008 (JSON-LD datePublished 2008-07-02) and "© 2026 Condé Nast. All rights reserved." |
| B1–B6 | Each is a substring of Gutenberg #972 (pg972-images.html) once the HTML's line wraps are collapsed, and each follows its own headword directly. CYNIC is its first sentence only. HYPOCRITE does lack the comma after "respect". All six also match the records HYPOCRITE/n, POLITICS/n, IMPARTIAL/adj, SELFISH/adj, CYNIC/n and INDISCRETION/n in priv/replay/bierce.jsonl.gz. The ebook page gives release Jul 1, 1997, last update Feb 23, 2026, "Produced by Aloysius and David Widger", "Public domain in the USA", and a summary saying the work was "published in complete form in 1911". The Author's Preface gives 1881 to 1906 and The Cynic's Word Book. |
Speakers are right throughout: the Hitchens passages come from signed pieces in his own voice, and the Bierce passages are his satirical definitions. The note's claim about Wikipedia (Hitchens's razor, citing a Kindle edition of God Is Not Great) also checks out.
3. Rights.
- Slate: 27 words (5 + 10 + 12) of about 1,070.
- Vanity Fair: 26 words (14 + 12) of about 2,800.
- Per passage: none is longer than 14 words.
- Rights notes: each source names its work and edition and says "In copyright", "fair use" and "check jurisdiction".
The quotations are brief, used for attribution and commentary, and substitute for nothing, so fair use is plausible. Bierce is public domain in the USA according to the Gutenberg record. RECOMMENDED 4 covers the locator wording.
4. Persona content.
- Highlights only. Both
selectionstrings say a seat judges highlights only and never votes the lead, and Bierce'sblind_spots[0]records the Bierce-first rule (LP-1). REQUIRED 1 concerns only the wording. - Disclosure. Both read "An AI selection lens inspired by …; not his voice or an assertion of his opinions about modern events, people or this dictionary". Both forbid an imagined endorsement and carry the Living curation: three to five personas reach a consensus on each visited page, visit-driven, two layers, per-kind staleness later, current events and living people bounded — design and MVP (under #193; after #298, with #299) #300 §6 living-person rule. Nothing claims to be the person or puts words in his mouth. The notes keep what is documented apart from our interpretation (Curation transparency: equal votes, reproducible selection, profiles and version history #203).
- INDISCRETION. It appears only in
locators, in one passage labelled "kept as a documented period prejudice, which is no part of the lens", and inblind_spots[2]. It is not inselection,principlesor either example, and Bierce'snegative_examplerejects sneering at a group. RECOMMENDED 3 covers thebasiswording. - Endorsement of prejudice. I found none. Hitchens's
blind_spotswarn against reading belief as fraud and say the lens carries none of his positions. His note says the lens takes no position on either essay's subject.
5. Deceased-status evidence: every value is as stated. The two LoC records were read from their .json serialisation, since the HTML pages refuse scripted fetches.
| Record | Confirmed |
|---|---|
LoC n84159549 (.json) |
Heading "Hitchens, Christopher". madsrdf:deathDate "2011-12-15" (EDTF) on the linked RWO rwo/agents/n84159549. A variant heading ends "1949-2011", and the record cites the New York Times, Dec. 16, 2011. |
| Wikidata Q49081 | P570 is 2011-12-15 at day precision. |
LoC n79100683 (.json) |
Heading "Bierce, Ambrose, 1842-1914?". deathDate "1914?". The "Wikipedia, 2012-03-08" citation note contains the quoted text verbatim; the elision is correct and "Chihauhua" is the record's spelling. |
| Wikidata Q191050 | P570 is 1914 at precision 9 (year), with qualifier P1480 = Q18122778 "presumably". P20 is Q61302, Chihuahua City, with the same qualifier, as the note says. |
6. The test file. In a detached worktree of the head, with MIX_ENV=test DD_NO_OBAN=1, PHX_SERVER unset and MIX_TEST_PARTITION=_r302, I ran persona_dossiers_test.exs through mix run --no-start with a small ExUnit runner: 7 tests, 0 failures. The file needs no application or database, so no test database was created. I did not run PersonaTest: it needs a database, and this PR touches neither Persona nor any Voltaire file.
I then mutated the JSON and re-ran the test. It caught 7 of 14 mutations:
| Caught (one test fails) | Not caught (7 of 7 pass) |
|---|---|
Bierce selection without its highlights-only clause |
12 extra 24-word in-copyright passages |
Bierce blind_spots without the lead-rule line |
an added passage that leaves the stated 27-word count stale |
| a 30-word in-copyright passage | disclosure without "inspired by" |
| the Vanity Fair source relabelled "Public domain" | INDISCRETION caveat removed and the entry made a principle |
an extra dossier key |
a misquoted Hitchens passage |
| Hitchens without a LoC reference | a misquoted Bierce passage |
a Hitchens selection that votes the lead |
a LoC URL with a different LCCN |
So the assertions are meaningful for shape, the highlights-only rule and the per-passage cap. RECOMMENDED 1, 2 and 5 cover the gaps.
7. Scope. The diff adds 5 files: the two notes, the two profile.json files and one test. Nothing is under lib/, priv/repo/ or config/, and mix.lock is untouched. On main, Persona reads only voltaire/v1 to v8, each by an explicit path. valid_version?/2 matches only slug voltaire, and nothing globs personas/. Nothing is admitted, registered, bound or activated. CodeRabbit reported no actionable comments, and the checks pass.
The worktree has been removed. I did not approve, merge or push.
The v7 whole-entry instruction appends the lens under "Selection lens:" after "DECIDE THE LEAD FIRST" and "One lead" (packet.ex:257-286), and #298 C9 keeps a model-selected lead on pages with no Bierce candidate. "The lens cannot choose or vote the lead" and "the lead comes from the Bierce-first lead rule" were therefore false for the D3 comparison arm. Both selections now read "The lead is set by the lead rule[, and its Bierce-first priority,] not by this lens: apply the lens to highlights only, and as a panel seat never vote the lead. The lens cannot change lead policy, ...", as Voltaire v8's "cannot change lead policy" does. Bierce's first blind spot says "Where the Bierce-first lead rule applies". The test asserts the new clause and refutes the old wording; both notes match. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1. The fair-use guard caps each in-copyright work at 50 quoted words in all,
as well as 25 per passage, and the "(N words" stated in `rights` must
equal the computed total.
2. The disclosure must say "An AI selection lens inspired by". A passage
whose speaker says "period prejudice" must say "no part of the lens", be
named in `blind_spots` and in `basis` as quoted only as a documented
prejudice, and stay out of `selection`, `principles` and both examples.
Only Bierce's INDISCRETION is flagged.
3. Bierce `basis` names the five entries the lens draws on and says
INDISCRETION is quoted only as a documented period prejudice; `rights`
says five entries and CYNIC's first sentence.
4. The Hitchens locators no longer quote the in-copyright text: Slate
paragraphs by number ("Paragraph 2 of 8"), Vanity Fair paragraphs by
subject. So the stated 27 and 26 words are the whole quotation; the rights
notes and the Hitchens note say so, and the note paraphrases the Slate
correction instead of quoting it.
5. Every Bierce passage must follow its own headword in
priv/replay/bierce.jsonl.gz (Gutenberg #972, pinned by the replay
MANIFEST). Each LoC or Wikidata reference must name, in `authority`, the
LCCN or QID its URL ends in. A comment says the Hitchens passages cannot
be checked offline.
The six mutations the review found uncaught (12 extra passages, a stale
word count, no "inspired by", INDISCRETION made a principle, a Bierce
misquote, a different LCCN) each now fail one test.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review response: all six items applied, new head
|
Independent exact-head re-review of
|
| Mutation | 5e31c4b | 00c8979 |
|---|---|---|
| 12 extra 24-word in-copyright passages | pass | caught |
| added passage, stated count left at 27 | pass | caught |
| disclosure without "inspired by" | pass | caught |
| INDISCRETION caveat removed and made a principle | pass | caught |
| Bierce misquote | pass | caught |
| Bierce passage under the wrong headword | n/a | caught |
| LoC URL with another LCCN; Wikidata URL with another QID | pass; n/a | caught; caught |
basis without the INDISCRETION sentence |
n/a | caught |
rights without a word count |
n/a | caught |
| old lead clause; lead-voting clause; no "as a panel seat…" | n/a; caught; n/a | caught (all three) |
| the seven caught before (highlights-only clause, lead-rule blind spot, 30-word passage, VF marked public domain, extra key, no LoC ref) | caught | caught |
| Hitchens misquote with the same word count | pass | pass (expected; the test comment says these are checked by hand) |
| INDISCRETION's text, in lower case, added as a principle ("…the guilt of woman as the measure of indiscretion") | n/a | pass |
INDISCRETION's text appended to positive_example |
n/a | pass |
| a quoted opening put back into a Slate locator | n/a | pass |
A shorter Hitchens misquote is caught, but only incidentally: it changes the word count.
RECOMMENDED
- Use the tracked Gutenberg file, not the ignored archive (
persona_dossiers_test.exs:14-16and:200-218).- The comment is wrong. It says
Sources.ManifestTest"already needs [priv/replay/bierce.jsonl.gz] on disk". It does not. "The real manifest" verifiespriv/sources/MANIFEST.json, which pins thedata/archives,priv/sources/bierce/972-h.htm,pg972.txtand the Johnson XML. Nothing in it pinspriv/replay/*.jsonl.gz, and I found no other test that reads that archive. - The dependency is new. This becomes the first test that needs a gitignored replay archive. Without it, the test fails loudly (
File.Errornaming the path). - It is acceptable, because precommit already needs the ignored
data/inputs and the PR has no CI test job. - But there is a better source. The tracked, sha256-pinned
priv/sources/bierce/972-h.htm(sha256849f63f2…, verified byManifestTest) contains all six passages directly after "HEADWORD, pos." once whitespace is collapsed. It is also the original the replay records were built from. - Suggestion. Read that file instead. Failing that, correct the comment.
- The comment is wrong. It says
- The prejudice guard is case-sensitive and checks only the headword (
persona_dossiers_test.exs:148-149). It refutes the upper-case "INDISCRETION" in the lens fields, so INDISCRETION's own text, written in lower case as a principle or appended topositive_example, passes 9 of 9. Suggestion: compare case-insensitively, and also refute the passage text (without its full stop) inselection,principlesand both examples. - Nothing checks that locators do not quote (
persona_dossiers_test.exs:174-191). Both Hitchensrightsnotes now say "the locators describe paragraphs rather than quote them", but putting a quoted opening back into a Slate locator still passes. Suggestion: for an in-copyright source, refute quotation marks (“ ” ") inlocatorsand in passagelocators.
The worktree has been removed. I did not approve, merge or push.
…locator guards 1. The Bierce check reads the tracked priv/sources/bierce/972-h.htm, whose sha256 priv/sources/MANIFEST.json pins and Sources.ManifestTest checks, instead of the gitignored priv/replay/bierce.jsonl.gz. The wrong comment about ManifestTest is gone. Each passage must follow "HEADWORD, pos." in the decoded, whitespace-collapsed text. 2. The prejudice guard compares case-insensitively and also refutes the flagged passage's own text (without its full stop) in `selection`, `principles` and both examples. 3. For an in-copyright source, no locator (source or passage) may contain a quotation mark, which backs the `rights` claim that locators describe paragraphs rather than quote them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Re-review response: the three RECOMMENDED items applied, new head
|
…ng (#304) - Q1: the history query test waits for the connected page's withheld-now read (render_async) before counting, so none of its queries lands in the measurement. - N1: passages show only when the rights note's first clause is "Public domain" or "Public domain in" an allowed jurisdiction (the USA, the United States, the UK...), optionally with a parenthetical source, and the note nowhere says "in part", "translation", "copyright" (other than "out of copyright"), "not", "except", "excluding" or "unless". #302's Bierce note now permits; "Public domain in part: ..." and "Public domain in the original French; ..." are refused. - N2: "n pages withheld whole, each because ..." for counts above one; the generic editor's layer label reads "No dossier, by design". - N3: a noscript line says the withheld-now count needs JavaScript. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Independent exact-head review of
|
Summary
This PR covers #300 item L2 only: two sourced persona dossiers, for Hitchens and Bierce, as reviewed data files. The owner asked for it on 3 November 2026: "Start ... the #300 L2 dossiers ... through a reviewable PR, with panel activation still gated on #298." The roster (Voltaire, Hitchens, Bierce, k = 2) is LP-1, recorded in c6562787916. The brief is c6562872837.
Nothing is admitted, registered, bound or activated. No runtime code changes, and
Agents.Personastill reads only the Voltaire manifests. There is no migration and no change toconfig/*.exsormix.lock. The persona-by-slug seam and the allowlists belong to #298 Part C (C4). Before either persona gets a seat, it is measured first as a comparison arm that publishes nothing, on matched evidence, under #298 Part D (D3 for Hitchens). Panel activation (L4) stays gated on #298 B5 PASS (LP-5).Cut from main
d33a6559533d23bc38aad00b4fcd5ea4d1ed35c5. First head5e31c4b; the review fixes are ind7f8970(REQUIRED 1) and00c8979(RECOMMENDED 1–5), and the re-review's test hardening is in2919d1a. Current head:2919d1a1582c91fe41f14770618077f758426467.Files
priv/curation/agents/personas/hitchens/v1/profile.json: templatehitchens-whole-entry-v1. The lens is "evidential support and consistency of argument" (Agent MVP: one autonomous curator on ten pages, then measured multi-agent consensus — under #193 #275 §4).priv/curation/agents/personas/bierce/v1/profile.json: templatebierce-whole-entry-v1. The lens is "hypocrisy, self-interest and precise satirical contrast" (Agent MVP: one autonomous curator on ten pages, then measured multi-agent consensus — under #193 #275 §4).docs/curation/personas/hitchens-v1.mdanddocs/curation/personas/bierce-v1.md: one page each on the sources, the rights, what is documented and what is our interpretation, and the hypothesis to test.test/devils_dictionary/curation/agents/persona_dossiers_test.exs: fixture-only, 9 tests, no database and no runtime support. The checks:voltaire/v8/profile.jsonat every level;<slug>-whole-entry-v1;rightsequals the computed total;blind_spotsandbasis, and absent, in any case and with its own text, fromselection,principlesand the examples;priv/sources/bierce/972-h.htm; the Hitchens passages cannot be checked offline, and a comment says so;authoritythe LCCN or QID its URL ends in.Both files copy v8's shape and serialisation (2-space JSON, ASCII escapes, trailing newline). Lead clause (reworded after review): "The lead is set by the lead rule[ and its Bierce-first priority], not by this lens: apply the lens to highlights only, and as a panel seat never vote the lead. The lens cannot change lead policy, source eligibility, meaning constraints or exact quotation." This holds both for the single-editor comparison arm, whose v7 instruction still has the model choose the lead by that rule (#298 C4, C9), and for a panel seat (#300 §4). Bierce's
blind_spotsadds that where the Bierce-first rule applies his own definition already heads the page (LP-1). Both say that a reason about a living person must quote or name the supplied source and never characterise the person (#300 §6).Sources
A script checked every passage on 3 Nov 2026 as an exact substring of the fetched page text. Bierce's passages were also checked against the project's own Bierce source records (
priv/replay/bierce.jsonl.gz, built from the same Gutenberg #972 HTML).The Hitchens quotations come to 27 words from the Slate column and 26 from the Vanity Fair essay. Since
00c8979the locators describe paragraphs (by number or subject) rather than quote their openings, so those counts are the whole quotation.Deceased-status evidence, from authority records:
deathDatedeathDateCould not verify, so left out
.jsonserialisation at the same path, and the dossiers cite the record URI.Tests
Run with
MIX_ENV=test DD_NO_OBAN=1,PHX_SERVERunset andMIX_TEST_PARTITION=_c300:persona_dossiers_test.exs) at2919d1a: 9 tests, 0 failures. Each of the six mutations the review found uncaught (12 extra passages, a stale word count, no "inspired by", INDISCRETION made a principle, a Bierce misquote, a different LCCN) now fails one test.mix precommitat2919d1a: 19 doctests, 3,340 tests, 0 failures (476.4 s, 22:32–22:40 UTC on 3 Nov, started only once no other precommit was running). Earlier heads:00c8979gave 19 doctests, 3,340 tests, 0 failures (after a first run lost 11 tests to sandbox queue timeouts from a concurrent precommit), and5e31c4bgave 19 doctests, 3,338 tests, 0 failures.An independent exact-head review will be arranged separately by the coordinating session.
🤖 Generated with Claude Code
Summary by CodeRabbit