Skip to content

#300 L2: Hitchens and Bierce dossiers as reviewed data files (nothing admitted) - #302

Merged
holden merged 4 commits into
mainfrom
claude/300-dossiers
Nov 4, 2026
Merged

holden merged 4 commits into
mainfrom
claude/300-dossiers

Conversation

@holden

@holden holden commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

Summary

This PR covers #300 item L2 only: two sourced persona dossiers, for Hitchens and Bierce, as reviewed data files. The owner asked for it on 3 November 2026: "Start ... the #300 L2 dossiers ... through a reviewable PR, with panel activation still gated on #298." The roster (Voltaire, Hitchens, Bierce, k = 2) is LP-1, recorded in c6562787916. The brief is c6562872837.

Nothing is admitted, registered, bound or activated. No runtime code changes, and Agents.Persona still reads only the Voltaire manifests. There is no migration and no change to config/*.exs or mix.lock. The persona-by-slug seam and the allowlists belong to #298 Part C (C4). Before either persona gets a seat, it is measured first as a comparison arm that publishes nothing, on matched evidence, under #298 Part D (D3 for Hitchens). Panel activation (L4) stays gated on #298 B5 PASS (LP-5).

Cut from main d33a6559533d23bc38aad00b4fcd5ea4d1ed35c5. First head 5e31c4b; the review fixes are in d7f8970 (REQUIRED 1) and 00c8979 (RECOMMENDED 1–5), and the re-review's test hardening is in 2919d1a. Current head: 2919d1a1582c91fe41f14770618077f758426467.

Files

  • priv/curation/agents/personas/hitchens/v1/profile.json: template hitchens-whole-entry-v1. The lens is "evidential support and consistency of argument" (Agent MVP: one autonomous curator on ten pages, then measured multi-agent consensus — under #193 #275 §4).
  • priv/curation/agents/personas/bierce/v1/profile.json: template bierce-whole-entry-v1. The lens is "hypocrisy, self-interest and precise satirical contrast" (Agent MVP: one autonomous curator on ten pages, then measured multi-agent consensus — under #193 #275 §4).
  • docs/curation/personas/hitchens-v1.md and docs/curation/personas/bierce-v1.md: one page each on the sources, the rights, what is documented and what is our interpretation, and the hypothesis to test.
  • test/devils_dictionary/curation/agents/persona_dossiers_test.exs: fixture-only, 9 tests, no database and no runtime support. The checks:
    • both files parse and carry exactly the keys of voltaire/v8/profile.json at every level;
    • the slug matches the directory and is a proposed profile slug, and the template version is <slug>-whole-entry-v1;
    • the dossier text is non-empty, the disclosure says "inspired by", and the selection carries the lead clause below and not the old wording;
    • the compiled instruction stays under the 1,800 bytes the Voltaire test allows;
    • every passage has text, a locator and a speaker, and every source has a rights note;
    • a work in copyright says "In copyright" and "fair use", each passage is at most 25 words, the work at most 50 in all, and the "(N words" in rights equals the computed total;
    • a passage kept as documented prejudice (only Bierce's INDISCRETION) is flagged as no part of the lens, named in blind_spots and basis, and absent, in any case and with its own text, from selection, principles and the examples;
    • every Bierce passage follows its own headword in the tracked, sha-pinned priv/sources/bierce/972-h.htm; the Hitchens passages cannot be checked offline, and a comment says so;
    • an in-copyright source's locators contain no quotation marks;
    • each persona's deceased-status evidence includes a Library of Congress authority record, and every LoC or Wikidata reference names in authority the LCCN or QID its URL ends in.

Both files copy v8's shape and serialisation (2-space JSON, ASCII escapes, trailing newline). Lead clause (reworded after review): "The lead is set by the lead rule[ and its Bierce-first priority], not by this lens: apply the lens to highlights only, and as a panel seat never vote the lead. The lens cannot change lead policy, source eligibility, meaning constraints or exact quotation." This holds both for the single-editor comparison arm, whose v7 instruction still has the model choose the lead by that rule (#298 C4, C9), and for a panel seat (#300 §4). Bierce's blind_spots adds that where the Bierce-first rule applies his own definition already heads the page (LP-1). Both say that a reason about a living person must quote or name the supplied source and never characterise the person (#300 §6).

Sources

A script checked every passage on 3 Nov 2026 as an exact substring of the fetched page text. Bierce's passages were also checked against the project's own Bierce source records (priv/replay/bierce.jsonl.gz, built from the same Gutenberg #972 HTML).

# Dossier Work Edition Locator Passage URL Rights
H1 Hitchens "Mommie Dearest" (Slate, Fighting Words) Slate, posted 20 Oct 2003, 1:04 PM PT, with its correction of 21 Oct 2003; Internet Archive capture of 23 Oct 2003 ¶2 of 8 "to test any extraordinary claims" https://web.archive.org/web/20031023010642/http://slate.msn.com:80/id/2090083 In copyright (page: ©2003 Microsoft Corporation); short quotation, fair use
H2 Hitchens same same ¶7 of 8 "a lazy media never bothered to ask any follow-up questions" same same
H3 Hitchens same same ¶8 of 8 (final) "what can be asserted without evidence can also be dismissed without evidence" same same
H4 Hitchens "Believe Me, It's Torture" Vanity Fair, August 2008 issue; online text dated 2 Jul 2008 Paragraph recounting the second session (Lincoln test) "if waterboarding does not constitute torture, then there is no such thing as torture." https://www.vanityfair.com/news/2008/08/hitchens200808 In copyright (page: © 2026 Condé Nast); short quotation, fair use
H5 Hitchens same same Paragraph on the veterans' two views "I think that both cases have to be stated at their strongest." same same
B1 Bierce The Devil's Dictionary Project Gutenberg eBook #972, released 1 Jul 1997, updated 23 Feb 2026 HYPOCRITE, n. "One who, professing virtues that he does not respect secures the advantage of seeming to be what he despises." https://www.gutenberg.org/ebooks/972 Public domain in the USA
B2 Bierce same same POLITICS, n. "A strife of interests masquerading as a contest of principles. The conduct of public affairs for private advantage." same same
B3 Bierce same same IMPARTIAL, adj. "Unable to perceive any promise of personal advantage from espousing either side of a controversy or adopting either of two conflicting opinions." same same
B4 Bierce same same SELFISH, adj. "Devoid of consideration for the selfishness of others." same same
B5 Bierce same same CYNIC, n. (first sentence) "A blackguard whose faulty vision sees things as they are, not as they ought to be." same same
B6 Bierce same same INDISCRETION, n. "The guilt of woman." (kept as a documented period prejudice, which is no part of the lens, per #203) same same

The Hitchens quotations come to 27 words from the Slate column and 26 from the Vanity Fair essay. Since 00c8979 the locators describe paragraphs (by number or subject) rather than quote their openings, so those counts are the whole quotation.

Deceased-status evidence, from authority records:

Dossier Authority Field Value URL
Hitchens Library of Congress NAF, LCCN n84159549 deathDate 2011-12-15 https://id.loc.gov/authorities/names/n84159549
Hitchens Wikidata Q49081 date of death (P570) 2011-12-15 https://www.wikidata.org/wiki/Q49081
Bierce Library of Congress NAF, LCCN n79100683 (heading "Bierce, Ambrose, 1842-1914?") deathDate 1914? https://id.loc.gov/authorities/names/n79100683
Bierce same record, source citation "Wikipedia, 2012-03-08" Source data found "d. after Dec. 26, 1913; [...] While traveling with rebel troops, the elderly writer disappeared without a trace (last seen in Chihauhua, Mexico)" (the record's spelling) same
Bierce Wikidata Q191050 date of death (P570), qualifier P1480 1914 (year precision); "presumably" https://www.wikidata.org/wiki/Q191050

Could not verify, so left out

  • God Is Not Great (Twelve, 2007). Its page or chapter for the assertion-and-evidence sentence could not be checked: the Internet Archive copy is restricted and the Google Books API was over quota. It is not cited. The same sentence is cited instead from the 2003 Slate column, verified in the Internet Archive capture.
  • The current Slate republication (slate.com) omits ¶8, so H3 is cited from the 2003 capture. H1 and H2 appear in both.
  • Letters to a Young Contrarian is not used, because no accessible copy could be checked.
  • Gutenberg #972's printed source is not named by Gutenberg. Only Gutenberg's summary says the work was "published in complete form in 1911". The dossier does not claim which printing the text follows.
  • The Library of Congress HTML pages return a bot challenge (HTTP 403) to scripted fetches. The two records were read from their .json serialisation at the same path, and the dossiers cite the record URI.

Tests

Run with MIX_ENV=test DD_NO_OBAN=1, PHX_SERVER unset and MIX_TEST_PARTITION=_c300:

  • Focused (persona_dossiers_test.exs) at 2919d1a: 9 tests, 0 failures. Each of the six mutations the review found uncaught (12 extra passages, a stale word count, no "inspired by", INDISCRETION made a principle, a Bierce misquote, a different LCCN) now fails one test.
  • mix precommit at 2919d1a: 19 doctests, 3,340 tests, 0 failures (476.4 s, 22:32–22:40 UTC on 3 Nov, started only once no other precommit was running). Earlier heads: 00c8979 gave 19 doctests, 3,340 tests, 0 failures (after a first run lost 11 tests to sandbox queue timeouts from a concurrent precommit), and 5e31c4b gave 19 doctests, 3,338 tests, 0 failures.

An independent exact-head review will be arranged separately by the coordinating session.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Added reviewed reference dossiers for Bierce and Hitchens, covering source evidence, interpretive limits, selection criteria, and conditions for abstaining. Both remain inactive and do not affect current curation behavior.
  • Tests
    • Added checks for dossier structure, required content, source attribution, and rights information. These checks do not activate or load the personas.

Two sourced persona dossiers in the exact shape of voltaire/v8/profile.json,
for the LP-1 roster (Voltaire, Hitchens, Bierce, k = 2):

- hitchens/v1 (hitchens-whole-entry-v1): five short quotations from two
  in-copyright works (Slate 2003, Vanity Fair 2008), each source with a
  rights note; deceased evidence from LoC n84159549 and Wikidata Q49081.
- bierce/v1 (bierce-whole-entry-v1): six entries from The Devil's
  Dictionary, Project Gutenberg #972 (public domain in the USA); the seat
  judges highlights only, since the Bierce-first lead rule already uses
  his text; deceased evidence from LoC n79100683 (1914?, "d. after Dec.
  26, 1913") and Wikidata Q191050.

One page of notes per dossier under docs/curation/personas, and a
fixture-only shape test. Nothing is admitted, registered or activated, and
no runtime code reads these files: the persona-by-slug seam is #298 Part C,
and each lens is first a non-publishing comparison arm under #298 Part D.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Warning

Review limit reached

  • Run on-demand review

This review includes 1 billable file and costs up to $0.25.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 7 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available. Your 56 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 16b0ff54-a2dd-4fdc-9291-9eab28908ffe
Commits

Reviewing files that changed from the base of the PR and between 00c8979 and 2919d1a.

Files selected for processing: 1
  • test/devils_dictionary/curation/agents/persona_dossiers_test.exs

No actionable comments were generated in the recent review.

Walkthrough

Adds inactive Bierce and Hitchens persona profiles and research dossiers. The profiles limit persona input to highlight selection. Fixture-only tests check dossier structure, selection rules, source metadata, quotation rights, and deceased-status evidence.

Changes: Persona dossiers

Layer / File(s) Summary
Persona profiles and dossiers
priv/curation/agents/personas/*/v1/profile.json, docs/curation/personas/*-v1.md
Adds Bierce and Hitchens profiles and dossiers with highlight-selection rules, source and rights records, examples, and evaluation criteria. The dossiers describe their inactive status and do not assign them lead-selection authority.
Fixture-only dossier validation
test/devils_dictionary/curation/agents/persona_dossiers_test.exs
Adds checks for data structure, selection rules, source metadata, quotation limits and rights declarations, Bierce passage matches, and deceased-status references. The tests do not load or activate personas.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related issues

Possibly related PRs

  • razrfly/dictionary#276: Adds the sourced persona profile and dossier workflow used for these additions.
  • razrfly/dictionary#279: Adds the whole-entry persona selection path and profile structure referenced by these profiles.
  • razrfly/dictionary#297: Adds the Voltaire profile structure and evidence-grounded selection guidance that the new profiles follow.
Merge Risk: Minimal · previous review 00c89

The dossiers remain inactive, and no merge-blocking issue was identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly summarizes the addition of reviewed Hitchens and Bierce dossiers and states that neither persona is admitted.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (4 skipped: 4 unsupported.)

Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: d9540b6a-d7b6-457d-9edf-8a07a554a2c5
Commits

Reviewing files that changed from the base of the PR and between 5e31c4b and 00c8979.

Files selected for processing: 5
  • docs/curation/personas/bierce-v1.md
  • docs/curation/personas/hitchens-v1.md
  • priv/curation/agents/personas/bierce/v1/profile.json
  • priv/curation/agents/personas/hitchens/v1/profile.json
  • test/devils_dictionary/curation/agents/persona_dossiers_test.exs
Files skipped from review as they are similar to previous changes: 2
  • docs/curation/personas/bierce-v1.md
  • priv/curation/agents/personas/hitchens/v1/profile.json

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

@holden

holden commented Nov 3, 2026

Copy link
Copy Markdown
Member Author

Independent exact-head review of 5e31c4b

I reviewed head 5e31c4bf17e6aad162e71c7d431e1a34b5f5eb21 only (merge base: main d33a655). I checked it against the L2 brief (c6562872837), #300 §4, §6, §7 and §11, LP-1 (c6562787916), #275 §4, #203 "Profiles and disclosure limits", and #298 C4, C9 and D3. I did not write this PR. I fetched every source on 3 Nov 2026.

Verdict: one REQUIRED change, the wording of the lead clause in both selection strings. The sources, rights, shape, deceased-status evidence and scope all check out. There are five RECOMMENDED items.

REQUIRED

  1. The lead clause contradicts the instruction it will be appended to as a comparison arm.
    • What the files say. priv/curation/agents/personas/hitchens/v1/profile.json:6 reads "Judge highlights only: the lens cannot choose or vote the lead". priv/curation/agents/personas/bierce/v1/profile.json:6 reads "Judge highlights only: the lead comes from the Bierce-first lead rule and is never voted".
    • Where they will be used. This PR names the file's first use: a non-publishing comparison arm (D3 for Hitchens). Curation agents: close out v6, retest v7, then controlled model and personality comparisons on identical packets (under #193) #298 C4 defines that arm as "instruction hitchens-whole-entry-v1 = v7 evidence policy plus the Hitchens lens", matched against Voltaire v7.
    • The conflict. On main, the lens is disclosure <> "\n" <> selection (lib/devils_dictionary/curation/agents/persona.ex:114-116). The v7 instruction appends it under "Selection lens:" (lib/devils_dictionary/curation/runtime/packet.ex:286). Earlier in that same prompt it says "DECIDE THE LEAD FIRST" (:257), "If a suitable lead exists, select it" (:259) and "One lead, at most twelve highlights" (:280). So the Hitchens arm would be told to choose a lead and also that it cannot choose one. The Voltaire v7 baseline's lens says only "The lens cannot change lead policy".
    • Why it matters. The two arms would differ in their lead instruction as well as their lens, and D3 and D6 report lead correctness.
    • Why it is not only a D3 problem. Curation agents: close out v6, retest v7, then controlled model and personality comparisons on identical packets (under #193) #298 C9 keeps a model-selected lead in every arm on pages with no priority candidate. So the clause is false there even under the fixed-lead arm, and the Bierce wording ("the lead comes from the Bierce-first lead rule") is false on those pages too.
    • Fix. Reword both clauses so they are true for a single-editor arm and for a panel seat. For example, for Hitchens: "The lead is set by the lead rule, not by this lens: apply the lens to highlights only, and as a panel seat never vote the lead. The lens cannot change lead policy, source eligibility, meaning constraints or exact quotation." For Bierce, use the same wording but name the Bierce-first rule. Then update the regex at test/devils_dictionary/curation/agents/persona_dossiers_test.exs:89 to match, and the matching sentence in each note.
    • Why now. Nothing is admitted yet. Once a profile version or an instruction hash is built from this text, it is immutable.

RECOMMENDED

  1. The test's fair-use guard is per passage only (persona_dossiers_test.exs:117-136). It caps each passage at 25 words. It does not cap the total per work, and it does not check the count the rights note states. In my mutation runs, 12 extra 24-word passages on the Slate source still passed 7 of 7. Adding one 14-word passage, while the note still says "Three short quotations (27 words)", also passed. Suggestion: cap the total words for each in-copyright source, and assert that the "(N words)" in rights equals the computed sum.

  2. Nothing guards the disclosure framing or the INDISCRETION caveat. The test checks the disclosure only for "not his voice" (persona_dossiers_test.exs:86) and never looks at INDISCRETION. Both of these mutations passed 7 of 7:

    • a Hitchens disclosure rewritten without "inspired by";
    • INDISCRETION with its caveat removed from speaker and from blind_spots, and added as a principle.

    Suggestion: assert disclosure =~ "inspired by". For any passage whose speaker says "period prejudice", also assert that the speaker says "no part of the lens", that blind_spots names its headword, and that selection, principles and the examples do not.

  3. The Bierce basis lumps INDISCRETION in with the lens (bierce/v1/profile.json:35). It says "These entries define virtue, principle and impartiality by the self-interest they conceal", which covers all six passages, INDISCRETION included. Suggestion: name the entries the lens draws on, and add that INDISCRETION is quoted only as a documented period prejudice. The speaker field (:64) and blind_spots (:15) already say this.

  4. The Hitchens word counts leave out the locator incipits.

    • What the files claim. hitchens/v1/profile.json:31 and :59 count 27 and 26 words. docs/curation/personas/hitchens-v1.md:38-39 says the dossier "reproduces nothing else".
    • What else is quoted. The locators also quote paragraph openings from the in-copyright texts: :26-28 adds 17 words from Slate, and :56-57 and :68 add 15 from Vanity Fair. The note also quotes the opening of the correction (hitchens-v1.md:45).
    • Suggestion. This is still clearly within fair-use plausibility, but I suggest "(27 words, plus short paragraph openings used as locators)" and qualifying "nothing else".
  5. The test does not check exact text or identifiers. A misquoted Hitchens passage passed 7 of 7, as did a misquoted Bierce passage and a LoC URL changed to a different LCCN. Hitchens cannot be checked offline. But Bierce's six passages could be asserted against their records in priv/replay/bierce.jsonl.gz, which the PR body already used for this check. Each LoC reference could also assert that the LCCN in authority equals the URL's last segment.

Evidence by check

1. Shape. I parsed voltaire/v8/profile.json from d33a655 and both new files.

  • Key sets and key order are identical at every level: top, dossier, source_refs[], passages[] and deceased_evidence_refs[]. So are the value types.
  • Re-serialising each file with 2-space indentation, ASCII escapes and a trailing newline reproduces it byte for byte (Hitchens 6,585 bytes, Bierce 6,020, Voltaire v8 2,556). None has a non-ASCII byte.
  • The compiled disclosure plus selection is 972 bytes for Hitchens and 975 for Bierce, under the 1,800 that persona_test.exs:89 allows.

2. Passages: 11 of 11 confirmed, and nothing I could not confirm.

# Confirmed
H1–H3 Exact substrings of the Internet Archive capture 20031023010642, in both the framed page and the id_ raw capture. They sit in body ¶2, ¶7 and ¶8 respectively. The column has 8 body paragraphs, about 1,070 words, followed by the Oct. 21 correction. The paragraph openings in locators, the byline, "Posted Monday, October 20, 2003, at 1:04 PM PT", "Fighting Words" and the 2003 Microsoft copyright line are all on the capture. The current slate.com republication contains H1 and H2 and ends at ¶7 and the correction, so ¶8 and H3 are absent. That matches the edition note.
H4–H5 Exact substrings of the Vanity Fair page, in the two paragraphs the locators name. The page shows "From the Magazine August 2008 Issue", the date July 2, 2008 (JSON-LD datePublished 2008-07-02) and "© 2026 Condé Nast. All rights reserved."
B1–B6 Each is a substring of Gutenberg #972 (pg972-images.html) once the HTML's line wraps are collapsed, and each follows its own headword directly. CYNIC is its first sentence only. HYPOCRITE does lack the comma after "respect". All six also match the records HYPOCRITE/n, POLITICS/n, IMPARTIAL/adj, SELFISH/adj, CYNIC/n and INDISCRETION/n in priv/replay/bierce.jsonl.gz. The ebook page gives release Jul 1, 1997, last update Feb 23, 2026, "Produced by Aloysius and David Widger", "Public domain in the USA", and a summary saying the work was "published in complete form in 1911". The Author's Preface gives 1881 to 1906 and The Cynic's Word Book.

Speakers are right throughout: the Hitchens passages come from signed pieces in his own voice, and the Bierce passages are his satirical definitions. The note's claim about Wikipedia (Hitchens's razor, citing a Kindle edition of God Is Not Great) also checks out.

3. Rights.

  • Slate: 27 words (5 + 10 + 12) of about 1,070.
  • Vanity Fair: 26 words (14 + 12) of about 2,800.
  • Per passage: none is longer than 14 words.
  • Rights notes: each source names its work and edition and says "In copyright", "fair use" and "check jurisdiction".

The quotations are brief, used for attribution and commentary, and substitute for nothing, so fair use is plausible. Bierce is public domain in the USA according to the Gutenberg record. RECOMMENDED 4 covers the locator wording.

4. Persona content.

5. Deceased-status evidence: every value is as stated. The two LoC records were read from their .json serialisation, since the HTML pages refuse scripted fetches.

Record Confirmed
LoC n84159549 (.json) Heading "Hitchens, Christopher". madsrdf:deathDate "2011-12-15" (EDTF) on the linked RWO rwo/agents/n84159549. A variant heading ends "1949-2011", and the record cites the New York Times, Dec. 16, 2011.
Wikidata Q49081 P570 is 2011-12-15 at day precision.
LoC n79100683 (.json) Heading "Bierce, Ambrose, 1842-1914?". deathDate "1914?". The "Wikipedia, 2012-03-08" citation note contains the quoted text verbatim; the elision is correct and "Chihauhua" is the record's spelling.
Wikidata Q191050 P570 is 1914 at precision 9 (year), with qualifier P1480 = Q18122778 "presumably". P20 is Q61302, Chihuahua City, with the same qualifier, as the note says.

6. The test file. In a detached worktree of the head, with MIX_ENV=test DD_NO_OBAN=1, PHX_SERVER unset and MIX_TEST_PARTITION=_r302, I ran persona_dossiers_test.exs through mix run --no-start with a small ExUnit runner: 7 tests, 0 failures. The file needs no application or database, so no test database was created. I did not run PersonaTest: it needs a database, and this PR touches neither Persona nor any Voltaire file.

I then mutated the JSON and re-ran the test. It caught 7 of 14 mutations:

Caught (one test fails) Not caught (7 of 7 pass)
Bierce selection without its highlights-only clause 12 extra 24-word in-copyright passages
Bierce blind_spots without the lead-rule line an added passage that leaves the stated 27-word count stale
a 30-word in-copyright passage disclosure without "inspired by"
the Vanity Fair source relabelled "Public domain" INDISCRETION caveat removed and the entry made a principle
an extra dossier key a misquoted Hitchens passage
Hitchens without a LoC reference a misquoted Bierce passage
a Hitchens selection that votes the lead a LoC URL with a different LCCN

So the assertions are meaningful for shape, the highlights-only rule and the per-passage cap. RECOMMENDED 1, 2 and 5 cover the gaps.

7. Scope. The diff adds 5 files: the two notes, the two profile.json files and one test. Nothing is under lib/, priv/repo/ or config/, and mix.lock is untouched. On main, Persona reads only voltaire/v1 to v8, each by an explicit path. valid_version?/2 matches only slug voltaire, and nothing globs personas/. Nothing is admitted, registered, bound or activated. CodeRabbit reported no actionable comments, and the checks pass.

The worktree has been removed. I did not approve, merge or push.

holden and others added 2 commits November 3, 2026 21:48
The v7 whole-entry instruction appends the lens under "Selection lens:"
after "DECIDE THE LEAD FIRST" and "One lead" (packet.ex:257-286), and #298
C9 keeps a model-selected lead on pages with no Bierce candidate. "The lens
cannot choose or vote the lead" and "the lead comes from the Bierce-first
lead rule" were therefore false for the D3 comparison arm.

Both selections now read "The lead is set by the lead rule[, and its
Bierce-first priority,] not by this lens: apply the lens to highlights
only, and as a panel seat never vote the lead. The lens cannot change lead
policy, ...", as Voltaire v8's "cannot change lead policy" does. Bierce's
first blind spot says "Where the Bierce-first lead rule applies". The test
asserts the new clause and refutes the old wording; both notes match.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1. The fair-use guard caps each in-copyright work at 50 quoted words in all,
   as well as 25 per passage, and the "(N words" stated in `rights` must
   equal the computed total.
2. The disclosure must say "An AI selection lens inspired by". A passage
   whose speaker says "period prejudice" must say "no part of the lens", be
   named in `blind_spots` and in `basis` as quoted only as a documented
   prejudice, and stay out of `selection`, `principles` and both examples.
   Only Bierce's INDISCRETION is flagged.
3. Bierce `basis` names the five entries the lens draws on and says
   INDISCRETION is quoted only as a documented period prejudice; `rights`
   says five entries and CYNIC's first sentence.
4. The Hitchens locators no longer quote the in-copyright text: Slate
   paragraphs by number ("Paragraph 2 of 8"), Vanity Fair paragraphs by
   subject. So the stated 27 and 26 words are the whole quotation; the rights
   notes and the Hitchens note say so, and the note paraphrases the Slate
   correction instead of quoting it.
5. Every Bierce passage must follow its own headword in
   priv/replay/bierce.jsonl.gz (Gutenberg #972, pinned by the replay
   MANIFEST). Each LoC or Wikidata reference must name, in `authority`, the
   LCCN or QID its URL ends in. A comment says the Hitchens passages cannot
   be checked offline.

The six mutations the review found uncaught (12 extra passages, a stale
word count, no "inspired by", INDISCRETION made a principle, a Bierce
misquote, a different LCCN) each now fail one test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@holden

holden commented Nov 3, 2026

Copy link
Copy Markdown
Member Author

Review response: all six items applied, new head 00c8979

This answers the independent review of 5e31c4b. The fixes are two new commits on claude/300-dossiers, with no force-push:

  • d7f8970 covers REQUIRED 1.
  • 00c8979 covers RECOMMENDED 1–5.

The new head is 00c8979ea30974b96965b65f67c60575cddb687c.

REQUIRED

1. The lead clause (d7f8970). Both selection strings now read:

"The lead is set by the lead rule[ and its Bierce-first priority], not by this lens: apply the lens to highlights only, and as a panel seat never vote the lead. The lens cannot change lead policy, source eligibility, meaning constraints or exact quotation."

  • This keeps Voltaire v8's "cannot change lead policy".
  • It is true for the D3 single-editor arm, whose v7 prompt still has the model choose the lead by the lead rule ("DECIDE THE LEAD FIRST", packet.ex:257), including on Curation agents: close out v6, retest v7, then controlled model and personality comparisons on identical packets (under #193) #298 C9 pages with no Bierce candidate. It is also true for a panel seat.
  • Bierce's first blind spot now begins "Where the Bierce-first lead rule applies".
  • The test asserts the new clause and refutes "cannot choose", "is never voted" and "Judge highlights only".
  • Both notes match. The compiled instruction is now 1,062 bytes for Hitchens and 1,039 for Bierce, still under 1,800.

RECOMMENDED (00c8979)

  1. Word totals. Each in-copyright work is now capped at 50 quoted words in all, as well as 25 per passage. The test also requires the "(N words" in rights to equal the computed total.
  2. Disclosure and INDISCRETION.
    • The disclosure must contain "An AI selection lens inspired by".
    • Any passage whose speaker says "period prejudice" must also say "no part of the lens". It must be named in blind_spots, and named in basis as "quoted only as a documented period prejudice". It must not appear in selection, principles or either example.
    • The test also asserts that the only such passage is Bierce's INDISCRETION.
  3. Bierce basis. It now names HYPOCRITE, POLITICS, IMPARTIAL, SELFISH and CYNIC as the five entries the lens draws on, and says INDISCRETION is quoted only as a documented period prejudice. rights now says "five short entries and the first sentence of CYNIC".
  4. Hitchens word counts. I took the "shorten" option.
    • The locators no longer quote the in-copyright text. Slate paragraphs are cited by number ("Paragraph 2 of 8" and so on, plus "Correction of Oct. 21, 2003, appended after paragraph 8"). Vanity Fair paragraphs are cited by subject ("Paragraph recounting the second session, which ends by applying a test attributed to Abraham Lincoln"; "Paragraph on the veterans' two views of whether waterboarding is torture").
    • So the stated 27 and 26 words are now the whole quotation. Both rights notes say the locators describe paragraphs rather than quote them.
    • hitchens-v1.md now says what it reproduces beyond the quotations: only the two titles and the pages' copyright notices. It paraphrases the correction instead of quoting its opening.
  5. Exact text and identifiers.
    • Every Bierce passage must follow its own headword in priv/replay/bierce.jsonl.gz. That is the project's Gutenberg #972 record set, pinned by the replay MANIFEST, and Sources.ManifestTest already needs it on disk.
    • Each LoC or Wikidata reference must name, in authority, the LCCN or QID its URL ends in, matched at a word boundary.
    • A test comment says the Hitchens passages cannot be checked offline and were checked against the named pages on 3 Nov.

Verification at 00c8979

  • Focused test (persona_dossiers_test.exs): 9 tests, 0 failures.
  • Your uncaught mutations: I re-ran the six that could be caught offline. Each now fails one test: 12 extra 24-word passages, a 14-word passage with the count left stale, a disclosure without "inspired by", INDISCRETION's caveat removed and the entry made a principle, a Bierce misquote, and a LoC URL with a different LCCN. A misquoted Hitchens passage still cannot be caught offline, as the comment says.
  • Passages: all 11 re-checked against their source pages by script. The current slate.com page still omits ¶8.
  • Files: both re-serialise byte for byte (2-space indentation, ASCII escapes, trailing newline). mix format --check-formatted passes.
  • Precommit: at 00c8979: 19 doctests, 3,340 tests, 0 failures (562.2 s, 22:11–22:21 UTC on 3 Nov, after the trial's 21:15–21:55 window), with MIX_ENV=test DD_NO_OBAN=1, PHX_SERVER unset and _c300. compile --warnings-as-errors and format were clean and changed nothing. The first run at this head (21:55–22:10) gave 11 failures. Every one was a DBConnection queue timeout in DataCase.setup_sandbox, while another session's precommit ran at the same time (worktree 298-part-c, load average about 15). Those 11 then passed under mix test --failed, and the full re-run above came after that session finished.

Nothing is admitted, registered or activated. No file under lib/, priv/repo/ or config/ changed, and neither did mix.lock.

🤖 Generated with Claude Code

@holden

holden commented Nov 3, 2026

Copy link
Copy Markdown
Member Author

Independent exact-head re-review of 00c8979

This re-review covers exact head 00c8979ea30974b96965b65f67c60575cddb687c. I reviewed the diff 5e31c4b..00c8979, which is d7f8970 and 00c8979, against my review of 5e31c4b (comment) and the author's reply (comment).

Verdict: nothing REQUIRED. REQUIRED 1 is fixed, and so are RECOMMENDED 1 to 5. There are three new RECOMMENDED items, all small test or comment hardening; none of them blocks the merge.

Previous items

REQUIRED 1, the lead clause: fixed. Both selection strings now say: "The lead is set by the lead rule[ and its Bierce-first priority], not by this lens: apply the lens to highlights only, and as a panel seat never vote the lead. The lens cannot change lead policy, …". I read it as compiled, appended under "Selection lens:" at the end of @whole_grounded (packet.ex:257-286 on main).

  • Single-editor arm. It no longer contradicts the prompt. The prompt's "DECIDE THE LEAD FIRST" section has the model choose the lead. The lens now says only that the lens plays no part in that choice, which agrees with the prompt's own lead section: "a neutral definition need not fit the personality's interests". The words "as a panel seat" are conditional and do not apply here.
  • Pages with no Bierce priority candidate (Curation agents: close out v6, retest v7, then controlled model and personality comparisons on identical packets (under #193) #298 C9). The model picks the lead under v7's "Otherwise choose a supplied definition…", and the lens still stays out of that choice, so the clause holds there.
    • On these pages Curation.LeadRule only permits a lead (:manual_fallback); it names none. So "set by the lead rule" means "chosen under the instruction's lead section", which is how both notes put it.
    • "Follows the lead rule" would be marginally more literal. It instructs nothing contradictory, so I am not raising it as an item.
  • C9 fixed-lead arm and panel seat. It holds in the fixed-lead arm, where code sets the lead, and for a panel seat (Living curation: three to five personas reach a consensus on each visited page, visit-driven, two layers, per-kind staleness later, current events and living people bounded — design and MVP (under #193; after #298, with #299) #300 §4).
  • Bierce. The Bierce-first priority is named as conditional, and blind_spots[0] now begins "Where the Bierce-first lead rule applies".
  • Size. The compiled instruction is 1,062 bytes for Hitchens and 1,039 for Bierce, under 1,800.
  • Test. It asserts the new clause and refutes "cannot choose", "is never voted" and "Judge highlights only". The old clause, a lead-voting clause, and the clause without "as a panel seat…" each fail one test.

RECOMMENDED 1 to 5: fixed.

  • Totals. Each in-copyright work now has a 50-word cap, and the "(N words" stated in rights must equal the computed sum.
  • Disclosure and INDISCRETION. The disclosure must contain "inspired by", and there is a guard on INDISCRETION.
  • Bierce basis. It names the five lens entries and says INDISCRETION is quoted only as a documented period prejudice.
  • Hitchens locators. They now describe paragraphs instead of quoting them. I checked the descriptions against the sources:
    • Slate ¶2, ¶7 and ¶8 are "of 8", and the topics are right.
    • Vanity Fair: the Lincoln-test paragraph is the one recounting his second attempt. The other locator is the paragraph on the veterans' two views.
  • Bierce text and identifiers. Each Bierce passage is checked against the replay records, and the LCCN or QID in authority against the URL.

Word counts and "reproduces" statements: accurate.

  • The quoted text is still 27 words from Slate and 26 from Vanity Fair, and the rights notes now say the locators do not quote.
  • I computed the longest word sequence shared with each source page for every Hitchens field outside the passages, titles and copyright notices.
    • In edition, basis, locators, the passage locators and the dossier strings, the longest is 5 words, a date line ("posted Monday, October 20, 2003"). The longest in a locator is 4 words, "whether waterboarding is torture", a plain description.
    • In hitchens-v1.md, the longest is the event name "in her Nobel Peace Prize lecture", in the paraphrase of the correction.
  • So "beyond the two titles and the pages' copyright notices, it reproduces nothing else" holds in substance.

Passages. All 11 passage texts, every source URL and every deceased-status reference are byte-identical to 5e31c4b, so the source checks in my first review still stand. Both files still match voltaire/v8's shape and serialise byte for byte.

Scope. No file under lib/, config/ or priv/repo/ changed, and neither did mix.exs or mix.lock. Nothing is admitted.

Tests

I used a detached worktree at 00c8979, with MIX_ENV=test DD_NO_OBAN=1, PHX_SERVER unset and MIX_TEST_PARTITION=_r302. The test ran under mix run --no-start, so no database was used. Result: 9 tests, 0 failures.

I ran 23 mutations, one at a time, each restored before the next. Each row is one test failing out of 9, or all 9 passing.

Mutation 5e31c4b 00c8979
12 extra 24-word in-copyright passages pass caught
added passage, stated count left at 27 pass caught
disclosure without "inspired by" pass caught
INDISCRETION caveat removed and made a principle pass caught
Bierce misquote pass caught
Bierce passage under the wrong headword n/a caught
LoC URL with another LCCN; Wikidata URL with another QID pass; n/a caught; caught
basis without the INDISCRETION sentence n/a caught
rights without a word count n/a caught
old lead clause; lead-voting clause; no "as a panel seat…" n/a; caught; n/a caught (all three)
the seven caught before (highlights-only clause, lead-rule blind spot, 30-word passage, VF marked public domain, extra key, no LoC ref) caught caught
Hitchens misquote with the same word count pass pass (expected; the test comment says these are checked by hand)
INDISCRETION's text, in lower case, added as a principle ("…the guilt of woman as the measure of indiscretion") n/a pass
INDISCRETION's text appended to positive_example n/a pass
a quoted opening put back into a Slate locator n/a pass

A shorter Hitchens misquote is caught, but only incidentally: it changes the word count.

RECOMMENDED

  1. Use the tracked Gutenberg file, not the ignored archive (persona_dossiers_test.exs:14-16 and :200-218).
    • The comment is wrong. It says Sources.ManifestTest "already needs [priv/replay/bierce.jsonl.gz] on disk". It does not. "The real manifest" verifies priv/sources/MANIFEST.json, which pins the data/ archives, priv/sources/bierce/972-h.htm, pg972.txt and the Johnson XML. Nothing in it pins priv/replay/*.jsonl.gz, and I found no other test that reads that archive.
    • The dependency is new. This becomes the first test that needs a gitignored replay archive. Without it, the test fails loudly (File.Error naming the path).
    • It is acceptable, because precommit already needs the ignored data/ inputs and the PR has no CI test job.
    • But there is a better source. The tracked, sha256-pinned priv/sources/bierce/972-h.htm (sha256 849f63f2…, verified by ManifestTest) contains all six passages directly after "HEADWORD, pos." once whitespace is collapsed. It is also the original the replay records were built from.
    • Suggestion. Read that file instead. Failing that, correct the comment.
  2. The prejudice guard is case-sensitive and checks only the headword (persona_dossiers_test.exs:148-149). It refutes the upper-case "INDISCRETION" in the lens fields, so INDISCRETION's own text, written in lower case as a principle or appended to positive_example, passes 9 of 9. Suggestion: compare case-insensitively, and also refute the passage text (without its full stop) in selection, principles and both examples.
  3. Nothing checks that locators do not quote (persona_dossiers_test.exs:174-191). Both Hitchens rights notes now say "the locators describe paragraphs rather than quote them", but putting a quoted opening back into a Slate locator still passes. Suggestion: for an in-copyright source, refute quotation marks (“ ” ") in locators and in passage locators.

The worktree has been removed. I did not approve, merge or push.

…locator guards

1. The Bierce check reads the tracked priv/sources/bierce/972-h.htm, whose
   sha256 priv/sources/MANIFEST.json pins and Sources.ManifestTest checks,
   instead of the gitignored priv/replay/bierce.jsonl.gz. The wrong comment
   about ManifestTest is gone. Each passage must follow "HEADWORD, pos." in
   the decoded, whitespace-collapsed text.
2. The prejudice guard compares case-insensitively and also refutes the
   flagged passage's own text (without its full stop) in `selection`,
   `principles` and both examples.
3. For an in-copyright source, no locator (source or passage) may contain
   a quotation mark, which backs the `rights` claim that locators describe
   paragraphs rather than quote them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@holden

holden commented Nov 3, 2026

Copy link
Copy Markdown
Member Author

Re-review response: the three RECOMMENDED items applied, new head 2919d1a

This answers the re-review of 00c8979. The fix is one new commit, 2919d1a. It changes only the test file (25 insertions, 25 deletions), with no force-push. The new head is 2919d1a1582c91fe41f14770618077f758426467.

  1. The Bierce check reads the tracked source.
    • It now reads priv/sources/bierce/972-h.htm, which priv/sources/MANIFEST.json pins by sha256 and Sources.ManifestTest verifies. It no longer reads the gitignored bierce.jsonl.gz.
    • The wrong comment about ManifestTest is gone.
    • Each passage must follow "HEADWORD, pos." in the decoded text, with whitespace collapsed.
  2. The prejudice guard is case-insensitive. It also refutes the flagged passage's own text, without its full stop, in selection, principles and both examples.
  3. No quotation marks in locators. For an in-copyright source, no locator may contain “, ” or ". This covers both the source's locators and each passage's locator.

Mutations. Each of your three new mutations now fails one test:

  • INDISCRETION's text in lower case as a principle fails the prejudice test.
  • INDISCRETION's text appended to positive_example fails the prejudice test.
  • A quoted opening put back into a Slate locator fails the copyright test.

A Bierce misquote and a passage under the wrong headword still fail the Bierce test against the new source.

Tests.

  • Focused test: 9 tests, 0 failures.
  • mix precommit at 2919d1a (_c300, started only once no other precommit was running): 19 doctests, 3,340 tests, 0 failures (476.4 s, 22:32–22:40 UTC on 3 Nov). compile --warnings-as-errors and format were clean and changed nothing.

Nothing else changed: the dossiers, notes, lib/, config/ and mix.lock are untouched, and nothing is admitted.

🤖 Generated with Claude Code

holden added a commit that referenced this pull request Nov 3, 2026
…ng (#304)

- Q1: the history query test waits for the connected page's withheld-now
  read (render_async) before counting, so none of its queries lands in
  the measurement.
- N1: passages show only when the rights note's first clause is "Public
  domain" or "Public domain in" an allowed jurisdiction (the USA, the
  United States, the UK...), optionally with a parenthetical source, and
  the note nowhere says "in part", "translation", "copyright" (other
  than "out of copyright"), "not", "except", "excluding" or "unless".
  #302's Bierce note now permits; "Public domain in part: ..." and
  "Public domain in the original French; ..." are refused.
- N2: "n pages withheld whole, each because ..." for counts above one;
  the generic editor's layer label reads "No dossier, by design".
- N3: a noscript line says the withheld-now count needs JavaScript.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@holden

holden commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

Independent exact-head review of 2919d1a

4 November 2026, by a fresh subagent of the #307 Stage 1 executor that had not seen the author's reasoning; posted verbatim by the executor.

What I read. git rev-parse HEAD in the 300-dossiers worktree is 2919d1a1582c91fe41f14770618077f758426467, which matches the PR's headRefOid. The PR is open and mergeable against main d33a655. I read:

  • the re-review of 00c8979 (RECOMMENDED 1–3) and the author's reply;
  • git diff 00c8979 2919d1a, which touches only persona_dossiers_test.exs (+25/−25);
  • the whole test file at the new head;
  • both profile.json dossiers;
  • the bierce entry in priv/sources/MANIFEST.json;
  • persona.ex:114-115, where the compiled instruction is disclosure followed by selection.

Across the whole PR, the diff from main still covers only the 5 data, doc and test files. lib/, config/ and priv/sources/ are unchanged.

The three items.

  1. Tracked source. The test now reads priv/sources/bierce/972-h.htm. Git tracks it, it is not ignored, and its sha256 849f63f2… matches the manifest. The incorrect ManifestTest comment has been replaced with an accurate one. Each passage must appear directly after "HEADWORD, pos." in the decoded text. Every headword-plus-marker string occurs exactly once in the text, so the substring check is in effect anchored to the entry.
  2. Prejudice guard. It is now case-insensitive and also refutes the passage text, without its full stop, in selection, principles and both examples.
  3. Locator guard. For in-copyright sources, both locators and each passage locator must not contain “, ” or ".

Meaningfulness. No edit to the worktree. A scratchpad script reproduced the guard logic in memory against the real files; each of these mutations was detected: a Bierce misquote; a wrong headword; a wrong part of speech; words appended to a passage; the passage text added as a lower-case principle; "Indiscretion" added to an example; curly or straight double quotes added to a locator or a passage locator. On the unmutated files every guard is false.

Tests. From the worktree, PHX_SERVER and DD_DATABASE_PORT unset (database port 5434):
env -u PHX_SERVER MIX_ENV=test DD_NO_OBAN=1 MIX_TEST_PARTITION=_s1b mix test test/devils_dictionary/curation/agents/persona_dossiers_test.exs test/devils_dictionary/curation/agents/persona_test.exs
Result: 14 tests, 0 failures in 2.2 s (seed 228810). mix format --check-formatted on the changed file exited 0; the worktree is still clean.

REQUIRED

None.

RECOMMENDED

  1. test/devils_dictionary/curation/agents/persona_dossiers_test.exs:141-145: add d["disclosure"] to the lens list, because disclosure is compiled into the model instruction alongside selection, and putting INDISCRETION's text there currently passes.
  2. test/devils_dictionary/curation/agents/persona_dossiers_test.exs:194: also refute the opening single quote ‘ (U+2018), because a locator quoting with single quotes currently passes, while ’ and ' have to stay allowed as apostrophes.

Verdict: mergeable at 2919d1a.

Executor's note: both RECOMMENDED items are test-only; to keep this PR at its reviewed head they are carried into the #307 pin PR (P3b), where the dossiers' lens is compiled into the Hitchens and Bierce instructions.

@holden
holden merged commit f63775a into main Nov 4, 2026
2 checks passed
@holden
holden deleted the claude/300-dossiers branch November 7, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant