Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Essentials Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This was referenced Sep 24, 2026
…eded through the entry path (#174) The seeder moves to DevilsDictionary.Corpus.Seeder now that it holds two kinds of content; DevilsDictionary.Artworks.Corpus.Seeder delegates to it for one release, and the artworks corpora's existing suites still call the old name, unchanged and green. A wikiquote-pd row is a content/quotation SourceIdentity.Entry in the live Wikiquote provider's shape, credited authored_by (verified) by QID, so a corpus line and a live line with one wording are one subject. Its stable identifier is the fingerprint, not wikiquote_item: that id is a position on the page at a revision, and a pinned corpus proposing it would claim whichever line sits there today. Quotations.Corpus.seed_row/3 writes a source record per line (the manifest row), the evidence the build found on the corpus's credit, and the Verified badge when the item has none. Authors are prepared from the manifest's own Wikidata facts, so seeding makes no request. Source row wikiquote-pd-v1: aristocracy, corpus, dump, CC BY-SA 4.0, the manifest checksum in its config. Records are never swept. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
holden
force-pushed
the
claude/wikiquote-corpus-seed
branch
from
September 24, 2026 13:33
a3cbc8f to
056a56f
Compare
Member
Author
17 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seeding for #174. Stacked on #176 (the build), which is stacked on #175.
The rename
DevilsDictionary.Artworks.Corpus.Seeder→DevilsDictionary.Corpus.Seeder(git mv).run/2,run_file/2,entry/3,catalog_counts/0) for one release.seeder_test.exsand the four corpus conformance suites are untouched and still call the old name.test/devils_dictionary/artworks(99 tests) is green.@deprecated: the gate compilestest/supportwith warnings as errors, and the old callers there are the proof. Remove it in the release after this.The quotations kind
entry("wikiquote-pd", …)builds acontent/quotationSourceIdentity.Entryin the live Wikiquote provider's shape. It is creditedauthored_byat:verifiedby the author's QID (P50field), so a corpus line and a live line with one wording are one subject. There is a test with a live Wikiquote entry first, then the seed: one item, two credits (wikiquote,wikiquote-pd-v1).Quotations.Corpus.seed_row/3writes, per line:wikiquote-pd-v1, keyed by fingerprint, whose payload is the manifest row:supportsevidence on the corpus credit (the Gutenberg locator, and the author's own page), oncecontent_items.metadata["provenance"], only when the item has none. An item the verifier has already seen keeps its badge until the verifier's own clock.selection.authorsthroughCreators.classify/2, so seeding makes no request.wikiquote-pd-v1:tier: :aristocracy,kind: :corpus,access: :dump, CC BY-SA 4.0, andconfigholdingdump_url,manifest_checksumandset_checksum(read from the committed file at compile time).Discovery.cleanup/0after a seed leaves every record, which is tested.mix dd.artworks.seed --manifest priv/quotes/manifests/wikiquote-pd-v1.jsonseeds it. Against the test database, the whole committed manifest seeds as 1,053 created and 0 invalid.What the code taught the issue
wikiquote_itemas an identifier on each corpus line. It must not be one. It is a hash of page, section and position at a revision. A corpus pinned to revision R would propose the id of whatever line sits at that position on today's page, and resolution would either conflict or record another line as an alternate text of this one. The corpus's stable identifier is the fingerprint.wikiquote_itemstays on the row as a locator.discovery_resultsrow is wrong for this corpus, as it is for the artworks one. Neither writesdiscovery_results: a corpus reaches the shelf at read time (PR 4).:refreshrewrites an entity's display keys. For a quotation it is skipped: a line's text is a revision and is never refreshed.MIX_TEST_PARTITION=_corpus174 mix precommit: 16 doctests, 1,884 tests, 0 failures.Refs #174.
🤖 Generated with Claude Code