Skip to content

Bing News on, by the owner's decision - #141

Merged
holden merged 1 commit into
mainfrom
codex/135-bing-on
Sep 21, 2026
Merged

holden merged 1 commit into
mainfrom
codex/135-bing-on

Conversation

@holden

@holden holden commented Sep 21, 2026

Copy link
Copy Markdown
Member

Follow-up to #140 and #135. The News shelf's first provider merged disabled because Bing's feed <copyright> reserves anything beyond a personal RSS aggregator to Microsoft's written permission. The owner read that and chose to run it and accept the risk (2026-09-21).

  • config/config.exs: enabled: true, with the decision and its date in the comment.
  • config/runtime.exs: the switch is inverted — BING_NEWS_ENABLED=false (shell or .env; the name is added to the .env allowlist) turns it off without a deploy.
  • docs/integrations/bing-news.md: the Shipped state row records who decided and when.

Tests: the Bing provider and conformance suites and providers_test green (61 tests); Application.get_env(:devils_dictionary, :bing_news)[:enabled] is true in dev.

🤖 Generated with Claude Code

…it off

#140 merged the provider disabled because the feed's <copyright> reserves
anything beyond a personal RSS aggregator to Microsoft's permission. The owner
read that and chose to run it (2026-09-21). The default is now true, the
runtime switch is inverted and also read from the local .env, and the
integration doc's shipped-state row says who decided and when.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

This review includes 3 billable files and costs up to $0.75.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 17 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available. Your 59 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Essentials

Run ID: e44c50df-8dc1-4d65-b5be-a235f4bb2d37

📥 Commits

Reviewing files that changed from the base of the PR and between 490a64f and 845e7ab.

📒 Files selected for processing (3)
  • config/config.exs
  • config/runtime.exs
  • docs/integrations/bing-news.md

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant