Repository navigation
Revert "[serve] Prevent routing tasks from abandoning pending requests (#66325)" - #66774
Closed
akyang-anyscale wants to merge 1 commit into
Closed
akyang-anyscale wants to merge 1 commit into
akyang-anyscale wants to merge 1 commit into
Conversation
ray-project#66325)" This reverts commit 5b14d65. Signed-off-by: akyang-anyscale <alexyang@anyscale.com> Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reverts #66325 so we can run the Serve microbenchmark release test against it. This is a draft for performance testing and is not meant to be merged as is.
In the nightly
serve_throughput_optimized_microbenchmarksrelease test,handle_model_comp_avg_rpsdropped from about 1,017 to about 143 requests per second between build 108436 (commitbe427bacd2, 2026-09-25) and build 108516 (commit5b14d650d7, 2026-09-26). Of the 15 commits in that window, #66325 is the only one that changes the Serve request path. The other candidate, #65660, makes a small change to lineage reconstruction inreference_counter.cc.A possible mechanism, which is not yet verified: after #66325, a routing task is cancelled when another task fulfills its request. As #66632 describes, the queue-length probes that task was waiting on are not cancelled with it, so their
get_num_ongoing_requestscalls keep running against replicas. If the throughput recovers on this branch, #66632 is a good candidate to test next as a forward fix.Caveat: this revert reintroduces the bug #66325 fixed. Under routers that match assignments to specific request IDs, a routing task can retire before it assigns its request, which can leave that request waiting indefinitely.
Related issues
Duplicate check
I searched open PRs referencing #66325. The only one is #66632, which is a forward fix for a flaky test, not a revert.
Tests
request_router.pyfrom [serve][LLM] Call on_request_routed for pick-only replica selections #66489 is untouched. The revert deletespython/ray/serve/tests/unit/test_request_router.py, which [serve] Prevent routing tasks from abandoning pending requests #66325 added. The unit test Bazel target collects tests withglob(["test_*.py"]), so no target references it by name.handle_model_comp_avg_rpswith master.AI assistance
AI assistance (Claude Code) was used to identify the suspect commit, prepare the revert, and write this description.
🤖 Generated with Claude Code