[dancingactor]

Description

After #63723 removed GCS-side PG resource restoration on scheduling failures and switched to relying on Raylet resource view broadcasts, GCS no longer needs to store PG-formatted resources in its cluster resource view.

Originally, these entries served two purposes:

• PG destruction cleanup: Determining which resources to restore when a PG is destroyed. This was already removed in [core] Remove PG resource deduction from GCS and rely on resource broadcast instead #63723.
• Commit phase partial failure: As noted in the

  ray/src/ray/gcs/gcs_placement_group_scheduler.cc

  Lines 501 to 502 in f02bd22

  	// Uncommitted bundles' resources stay subtracted in GCS's view until the
  	// next ray-syncer message from each raylet brings the actual state back.

  this now also relies on Raylet sync to reconcile the GCS resource view.

Since neither path uses these entries anymore, this PR removes PG-formatted resources from the GCS cluster resource view.

Related PR

Related to #63723

[gemini-code-assist]

Code Review

This pull request removes the CommitBundleResources method and its helper ToNodeBundleResourcesMap from GcsPlacementGroupScheduler. The review feedback suggests further cleaning up the codebase by removing the now-unused commited_bundle_locations map and its population logic to avoid unnecessary overhead, as well as removing the IsPlacementGroupWildcardResource helper method and its corresponding unit tests since they have become dead code.

I am having trouble creating individual review comments. Click here to see my feedback.

src/ray/gcs/gcs_placement_group_scheduler.cc (386-391)

With the removal of CommitBundleResources, the commited_bundle_locations map is now populated but never used. We should clean up this unused variable and the loop that populates it to avoid unnecessary memory allocation and overhead.

Here is how the lambda can be simplified:

    auto commit_resources_callback = [this,
                                      lease_status_tracker,
                                      bundles_per_node,
                                      node_id,
                                      schedule_failure_handler,
                                      schedule_success_handler](const Status &status) {
      for (const auto &bundle : bundles_per_node) {
        lease_status_tracker->MarkCommitRequestReturned(node_id, bundle, status);
      }

      if (lease_status_tracker->AllCommitRequestReturned()) {
        OnAllBundleCommitRequestReturned(
            lease_status_tracker, schedule_failure_handler, schedule_success_handler);
      }
    };

src/ray/gcs/gcs_placement_group_scheduler.cc (761-762)

Since CommitBundleResources has been removed, the helper method IsPlacementGroupWildcardResource is now dead code and no longer used anywhere in the class (except for its unit test TestCheckingWildcardResource).

Consider removing IsPlacementGroupWildcardResource from both the source and header files, along with its corresponding unit test, to keep the codebase clean and maintainable.

[cursor]

Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.

^{Reviewed by Cursor Bugbot for commit ee855a0. Configure here.}

[Yicheng-Lu-llll]

LGTM! just one nit: please also drop the unused commited_bundle_locations IsPlacementGroupWildcardResource etc.

[dancingactor]

@Yicheng-Lu-llll Thanks for review! I've already removed that unused code as well