Repository navigation
[cherry-pick][2.58.0][core][taskEvents out of GCS][10/n] Fix bugs found after migration (#65247) - #65360
Merged
elliot-barn merged 1 commit intoAug 11, 2026
Conversation
…65247) Part of the effort to move task events out of GCS. This PR builds on top of #65218 To test the entire feature, I took changes from PR 2/n to 9/n, changed the flags so that `task_event_buffer` to GCS is stopped, `ray_task_event_recorder` is used, task events are sent to task events head via aggregator agent, and state APIs and ray timeline consume task events from task event head. essentially these flags were configured: `enable_ray_event: true` `enable_ray_task_event_recorder: true` `enable_task_events_to_dashboard_head: true` `enable_core_worker_task_event_to_gcs: false` Some issues in tests were found. This PR resolves those issues, so that premerge tests pass even even after we switch the flags ON default --------- Signed-off-by: Kartica Modi <karticamodi@gmail.com> (cherry picked from commit 4a3d4ea) Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request prepares Ray for migrating task profiling event reads from GCS to the Ray dashboard. It adds a warning to ray.timeline(), updates StateDataSourceClient instantiation in tests to include dashboard socket and session parameters, and refactors various tests to use environment variables (via monkeypatching) so that dashboard-head subprocesses correctly inherit configurations. I have no feedback to provide as there are no review comments.
elliot-barn
deleted the
elliot-barn/cherry-pick-2.58.0-task-events-bugfixes-65247-v2
branch
August 11, 2026 03:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #65247 (master commit 4a3d4ea) onto
releases/2.58.0. Final part of the series — the branch now carries 1/n–6/n (7/n shipped inside the 6/n squash), 8/n, 9/n, and 2.5/n in master-chronological order.One conflict, manually resolved (
test_aggregator_agent.py): the original commit adds"RAY_enable_ray_event": "0"(+ comment) to a test env dict and deletes two adjacent TODO comment lines that exist only on master (from an unpicked commit). The release branch never had those TODO lines, so the resolution takes the addition as-is; the resulting test content matches master's post-#65247 state for that hunk. All other 7 files applied cleanly.git cherry-pick -x -s; 8 files, +107/−27 (vs +106/−29 on master — delta is exactly the two never-present TODO deletions). Pre-commit hooks pass. AI-assisted (Claude Code); submitted and reviewed by @elliot-barn.🤖 Generated with Claude Code