Repository navigation
Read OpenAI settings when the server leaves out null fields - #327
Merged
poissoncorp merged 1 commit intoNov 17, 2026
Merged
Conversation
The server omits null fields when it returns a server-wide AI connection string, so an OpenAI connection string put without an endpoint comes back with no Endpoint key. OpenAiSettings.from_json indexed ApiKey, Endpoint and Model directly and raised KeyError, which broke GetServerWideConnectionStringsOperation and GetConnectionStringsOperation for such connection strings. Read them with get(), like the other AI provider settings do.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RDBC-1200 Fix Python SDK vs 7.2.8 server
The server omits null fields from AI connection strings that come from a server-wide connection string. An OpenAI connection string put without an endpoint comes back with no
Endpointkey, andOpenAiSettings.from_jsonraisedKeyError: 'Endpoint'in bothGetServerWideConnectionStringsOperationandGetConnectionStringsOperation.ApiKey,EndpointandModelare now read withget(), like the other AI provider settings.Tests
test_open_ai_settings.pyparses the payload the server actually returns. It needs no server, so it runs on CI.test_ravenDB_24310failed with theKeyErroron every 7.2 server and pass now.