Repository navigation
Replace FakeTensorUpdater copy with Torch import - #4260
Merged
narendasan merged 1 commit intoMay 20, 2026
Merged
Conversation
github-actions
Bot
added
component: lowering
benjaminglass1
force-pushed
the
update_faketensorupdater_init
branch
from
May 15, 2026 16:05
ea959c9 to
0d093c7
Compare
Contributor
Author
|
Updated with a compatibility patch, to handle the fact that this code is not in a release yet. |
benjaminglass1
marked this pull request as ready for review
May 15, 2026 16:06
Collaborator
|
@cehongwang Can you review when you get back? |
benjaminglass1
force-pushed
the
update_faketensorupdater_init
branch
from
May 15, 2026 17:03
0d093c7 to
8567fbe
Compare
Contributor
Author
|
As far as I can tell, test failures are unrelated to this PR. @cehongwang Can you merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#4017 added a copy of
torch._inductor.fx_utils.FakeTensorUpdaterto the repo, with some minor changes. The original class is being updated to handle subgraphs and HOPs, and fix corner cases, in pytorch/pytorch#159523. Rather than once again copying all the new code over, I've changed to subclassing fromFakeTensorUpdaterand only implementing the interface changes.Type of change
Checklist: