GH-148468: Accept string-like proxy objects in colorized argparse help - #154653
Merged
savannahostrowski merged 5 commits intoJul 30, 2026
Merged
Conversation
savannahostrowski
added
the
needs backport to 3.15
Member
Author
|
@hugovk (since it's colour-related) @clytaemnestra Perhaps one or both of you have some cycles to review this one :) ? |
Member
|
I left a comment at #148468 (comment) that I can no longer repro the MRE with latest 3.15 and Is this change still needed or useful? |
Member
Author
|
Yes, seems like it. #148468 (comment) |
hugovk
reviewed
Jul 29, 2026
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Savannah Ostrowski <savannah@python.org>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
savannahostrowski
enabled auto-merge (squash)
July 30, 2026 15:30
Member
Author
|
Thanks for the quick review, Hugo! And for being so thorough! |
|
Thanks @savannahostrowski for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15. |
|
GH-154946 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.