Skip to content

gh-112302: Point core developers to SBOM devguide on errors#113490

Merged
hugovk merged 3 commits into
python:mainfrom
sethmlarson:sbom-devguide-on-error
Jan 10, 2024
Merged

gh-112302: Point core developers to SBOM devguide on errors#113490
hugovk merged 3 commits into
python:mainfrom
sethmlarson:sbom-devguide-on-error

Conversation

@sethmlarson

@sethmlarson sethmlarson commented Dec 26, 2023

Copy link
Copy Markdown
Contributor

Follow-up from python/devguide#1251, this adds a helper which errors out during validation and provides a helpful link to the SBOM devguide.

@sethmlarson
sethmlarson force-pushed the sbom-devguide-on-error branch from 964d596 to fc699a0 Compare December 26, 2023 15:00
@sethmlarson
sethmlarson requested a review from hugovk December 28, 2023 17:17
Comment thread Tools/build/generate_sbom.py Outdated
@sethmlarson
sethmlarson requested a review from hugovk January 10, 2024 17:33

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread Tools/build/generate_sbom.py Outdated
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@sethmlarson

Copy link
Copy Markdown
Contributor Author

Last suggestion committed, thanks @hugovk for the reviews! :)

@hugovk
hugovk enabled auto-merge (squash) January 10, 2024 19:10
@hugovk
hugovk merged commit e82b096 into python:main Jan 10, 2024
@sethmlarson
sethmlarson deleted the sbom-devguide-on-error branch January 10, 2024 19:23
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
…thon#113490)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
…thon#113490)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
…thon#113490)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants