Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 19 additions & 13 deletions src/packaging/version.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,9 @@ class InvalidVersion(ValueError):


class _BaseVersion:
_key: tuple[Any, ...]
@property
def _key(self) -> tuple[Any, ...]:
raise NotImplementedError # pragma: no cover

def __hash__(self) -> int:
return hash(self._key)
Expand Down Expand Up @@ -195,7 +197,7 @@ class Version(_BaseVersion):

_regex = re.compile(r"\s*" + VERSION_PATTERN + r"\s*", re.VERBOSE | re.IGNORECASE)
_version: _Version
_key: CmpKey
_key_cache: CmpKey | None

def __init__(self, version: str) -> None:
"""Initialize a Version object.
Expand All @@ -212,8 +214,6 @@ def __init__(self, version: str) -> None:
match = self._regex.fullmatch(version)
if not match:
raise InvalidVersion(f"Invalid version: {version!r}")

# Store the parsed out pieces of the version
self._version = _Version(
epoch=int(match.group("epoch")) if match.group("epoch") else 0,
release=tuple(int(i) for i in match.group("release").split(".")),
Expand All @@ -225,15 +225,21 @@ def __init__(self, version: str) -> None:
local=_parse_local_version(match.group("local")),
)

# Generate a key which will be used for sorting
self._key = _cmpkey(
self._version.epoch,
self._version.release,
self._version.pre,
self._version.post,
self._version.dev,
self._version.local,
)
# Key which will be used for sorting
self._key_cache = None

@property
def _key(self) -> CmpKey:
if self._key_cache is None:
self._key_cache = _cmpkey(
self._version.epoch,
self._version.release,
self._version.pre,
self._version.post,
self._version.dev,
self._version.local,
)
return self._key_cache

def __repr__(self) -> str:
"""A representation of the Version that shows all internal state.
Expand Down
Loading