Repository navigation
Finalize change in behavior of decode_timedelta=None - #11173
Merged
keewis merged 1 commit intoFeb 19, 2026
Merged
Conversation
kmuehlbauer
approved these changes
Feb 19, 2026
dcherian
approved these changes
Feb 19, 2026
keewis
approved these changes
Feb 19, 2026
keewis
left a comment
keewis
left a comment
Collaborator
There was a problem hiding this comment.
I didn't check the tests, but otherwise looks good to me.
Member
Author
|
Thanks all |
tonybaloney
pushed a commit
to tonybaloney/swe-complex-xarray
that referenced
this pull request
Mar 19, 2026
PR: pydata#11173 Issue: pydata#10382 Base commit: a2c5464 Changed lines: 113
5 tasks done
ShinoKana
added a commit
to ShinoKana/xarray
that referenced
this pull request
Oct 13, 2026
- reset_encoding warned with a plain UserWarning and the wrong version; it now uses FutureWarning like the other deprecations, and 2023.10. - cftime_range's docstring cited 2025.02.0, which was never released. - Drop the leftover decode_timedelta warnings filter; that change was finalized in pydata#11173. - DataTree.lineage warned twice because it went through iter_lineage. Co-authored-by: Claude <noreply@anthropic.com>
6 tasks done
headtr1ck
pushed a commit
that referenced
this pull request
Oct 14, 2026
* Small deprecation cleanups from #11721 - reset_encoding warned with a plain UserWarning and the wrong version; it now uses FutureWarning like the other deprecations, and 2023.10. - cftime_range's docstring cited 2025.02.0, which was never released. - Drop the leftover decode_timedelta warnings filter; that change was finalized in #11173. - DataTree.lineage warned twice because it went through iter_lineage. * Annotate the object list in test_reset_encoding_deprecated for mypy --------- Co-authored-by: ShinoKana <ShinoKana@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
6 tasks done
zhaoruizhe81
added a commit
to zhaoruizhe81/xarray
that referenced
this pull request
Oct 17, 2026
Since pydata#11173, decode_timedelta=None only decodes variables whose attributes contain both a timedelta units attribute and a dtype attribute, regardless of decode_times. The docstrings of open_dataset, open_dataarray, open_datatree, open_groups, open_zarr, decode_cf and decode_cf_variable still described the pre-pydata#11173 behavior, and the CFTimedeltaCoder.decode_via_units docstring said it defaults to True when the signature default is False. Rewrite them to match the actual behavior (fixing a decode_time typo in open_zarr along the way) and add a units-only zarr regression test pinning the None behavior end to end. No behavior is changed. Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR finalizes the deprecation cycle in the behavior of
decode_timedelta=None. Xarray will now no longer by default decode variables with only a timedelta-like"units"attribute intonp.timedelta64values.whats-new.rst