Repository navigation
release v0.18.0 #5232
Description
As discussed in the meeting, we should issue a release soon with the new backend refactor and the new docs theme.
Here's a list of blockers:
- open_mfdataset: Raise if combine='by_coords' and concat_dim=None #5231
-
lockkwarg needs a deprecation cycle? #5073 - Fix exception when display_expand_data=False for file-backed array. #5235
Would be nice and look done:
- Add GitHub action for publishing artifacts to PyPI #5244
- Bump versions #5258
- Surface plots #5101
-
Refactor line plotting #4866(we should let this sit on master for a while to find bugs) - also apply combine_attrs to the attrs of the variables #4902
-
Automatic duck array testing - reductions #4972(this should probably also sit on master for a while) - coarsen: better keep_attrs #5227
- Faster interp #4740
- Convert attribute and dimension names to strings when generating HTML repr #5149
Somewhat important, but no PR yet:
-
Feature to retrieve the underlying store #5175(as pointed out by @shoyer, this is really a new feature, not a regression, it can wait)
@TomNicholas and @alexamici volunteered to handle this. I can be online at release time to help with things if needed.
Release instructions are here: https://github.com/pydata/xarray/blob/master/HOW_TO_RELEASE.md
IIRC they'll need to be added to the PyPI list and RTD list.
Activity
Illviljan commentedon Apr 30, 2021
May I suggest #4740, the only thing this needs I think is a rebase. I recently got a new computer and was reminded how slow the interpolation is without these changes.
alexamici commentedon Apr 30, 2021
I propose the following timeline that is the fastest I can personally try:
@TomAugspurger and others does it work for you all?
TomNicholas commentedon Apr 30, 2021
@alexamici I think you tagged the wrong Tom, but yes that works for me.
max-sixty commentedon Apr 30, 2021
I think @alexamici 's plan is reasonable. I've had less of a process — no freeze etc — and that's worked fine — we do have a good test suite, and I've been really trying to make the release process a normal thing anyone can do in an hour.
But it's your call (and there's not much practical difference).
Thanks again!
dcherian commentedon Apr 30, 2021
We can avoid this by using the pypi github action thing to automatically build and upload when tagging a release on github. It uses a repo-level secret. Just a thought.
I added @alexamici . @TomNicholas you need to sign up on RTD before I can add you there as a maintainer
dopplershift commentedon Apr 30, 2021
$0.02 from an outsider is that this has served us exceedingly well on MetPy. Our release process has become:
It's almost more secure this way because the token from PyPI only has upload permissions--no need to store someone's password.
TomNicholas commentedon May 3, 2021
(@dcherian I've signed up on RTD now)
keewis commentedon May 3, 2021
great, you're a maintainer now (for
pint-xarray, too, btw)dcherian commentedon May 4, 2021
It'd be nice to bump our minimum dependency versions if someone has the time.
alexamici commentedon May 5, 2021
Form what I can see the #5258 "bump versions" looks ready, someone with knowledge about minimum versions please merge it.
After that is in, @dcherian you can probably uncomment the
var._metabit in #4740 "faster interp" and we can merge it as well. Again I'm not a user of that part of code, and I would feel more conformable if someone with more knowledge would click on the "merge" button.This leaves only #5235 as a blocker that has a failing test, a proposed fix by @keewis.
but the OP hasn't responded yet. How should we handle it?This looks ready to merge now. Sorry @tomwhite I read the timestamps wrong. Great job!alexamici commentedon May 5, 2021
Any thoughts on merging #5244 and doing the v0.18.0 release via GitHub Actions?
I'm using GA in a couple of repositories and I find them very handy, but I usually had to make a couple of releases before getting all the details right, which looks awkward to do with a high profile project like xarray.
We could try release one or more release candidates and go for
v0.18.0only after we are sure the GA release procedure is working though.keewis commentedon May 5, 2021
we could also temporarily switch the uploads to
test.pypi.orgto verify, create debug versions (rc candidates?) and switch back topypi.orgonce we're confidentkmuehlbauer commentedon May 5, 2021
Why not always upload pushes to master to
test.pypi.org?keewis commentedon May 5, 2021
I think that's because nobody had that idea, yet.
Edit: that would also help with the idea in #5244 (comment). Let's continue that discussion in #5244
alexamici commentedon May 6, 2021
@TomNicholas & @dcherian I'm having a look at the what's new, shall we set a time for going through the release process? do we want do the steps while in a call?
33 remaining items
dcherian commentedon May 6, 2021
Yup, nice work everyone!
https://pypi.org/project/xarray/
keewis commentedon May 6, 2021
ah, right, only the "push tag" workflow run failed
alexamici commentedon May 6, 2021
I'm testing after
pip install -U xarrayjust to be on the safe side 😄TomNicholas commentedon May 6, 2021
Alright I'll carry on with the other steps then I guess? 😅
TomNicholas commentedon May 6, 2021
How many xarray devs does it take to do a release? Answer: at least 5 apparently
alexamici commentedon May 6, 2021
🤦
But next time it will be sooooooo smooth!
andersy005 commentedon May 6, 2021
Or we could just set
on the upload to TestPyPI step.
TomNicholas commentedon May 6, 2021
Okay that should be everything except emailing the mailing lists, which I will try now
alexamici commentedon May 6, 2021
12899 passed, 1145 skipped, 211 xfailed, 63 xpassed, 321 warningson my Mac.alexamici commentedon May 6, 2021
@TomNicholas feel free to close the issue once you are done.
TomNicholas commentedon May 6, 2021
My email got bounced from pyaos@lists.johnny-lin.com because I'm not a member, but otherwise I think this is done. (I'm also not subscribed to numpy-discussion@scipy.org or scipy-user@scipy.org so maybe it's about to get bounced from there too).
TomNicholas commentedon May 6, 2021
I updated the release guide in #5274 by the way.
dcherian commentedon May 6, 2021
Nice work, @TomNicholas
shoyer commentedon May 6, 2021