Repository navigation
release(v0.58.0): "Delete the thing you replaced" - #1010
Merged
Merged
Conversation
…11/11, version pin sweep All 11 RQ-58-* artifacts are implemented and merged, so the release-readiness query over artifacts/release-v0.58.yaml is satisfied. Every number in the CHANGELOG was re-derived from MERGED CODE at this commit, not from PR bodies (v0.57's cold review found 4 factual errors in release prose written the same way): DSL rules 50 -> 74 (coq/vcr_sel_rules.manifest, tag vs HEAD) 1:1 Qed theorems 50 -> 74 (VcrSelRules.v) Rocq Qed (suite) 592 -> 617 (2 Admitted, 2 admit.) selector code 18,480 -> 17,961 selector wildcards 62 -> 55 selector total 29,616 -> 28,582 TWO CORRECTIONS the cold review caught in my own draft: 1. The v0.57.0 code-region baseline is 18,480 / 62 wildcards, NOT 18,582 / 63. The latter pair is the METRIC pin's CREATION value — measured mid-v0.58 after #992 grew the file — not the v0.57.0 release value. Re-measured at the tag with the ratchet's own marker ('#[cfg(test)]\nmod tests', asserted unique) so the release-over-release delta is like-for-like. 2. The SPLIT bullet originally read 'the root file went 29,616 -> 18,284', which is true release-over-release but credits SPLIT with a drop that RETIRE (-1,312) and SELDSL (-79) partly produced. Corrected to SPLIT's own effect: 10,298 lines moved out, 28,533 -> 18,284. Locally-true sentence, wrong attribution — the same shape as all four v0.57 errors. Version pin sweep across all four surfaces + Cargo.lock: check_version_pins.py exits 0 at 0.58.0. claim_check 49/49, model_coverage_audit --check ok, fmt clean. Refs #242.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All 11 of 11
RQ-58-*artifacts are implemented and merged, so the release-readiness query overartifacts/release-v0.58.yamlis satisfied.The release in one number
Qed(whole suite)The first release in the epic's history where the selector shrank while the verified rule count grew. From v0.42.0 → v0.57.0 it had gone the other way: 24,909 → 29,616 lines (5,515 added / 808 deleted, 6.8:1) while verified rules went 40 → 50 and sat flat for twelve releases.
Every number re-derived from merged code
Not from PR bodies — v0.57's cold review found 4 factual errors in release prose written the same way, by the same author. Sources:
coq/vcr_sel_rules.manifestandVcrSelRules.vat tag vs HEAD; thecoq/Synthtree; the selector files measured with the ratchet's own region marker.Two corrections the cold review caught in my own draft:
The v0.57.0 baseline is 18,480 / 62 wildcards, not 18,582 / 63. The latter pair is the METRIC pin's creation value — measured mid-v0.58 after fix(#973): ARM select on an i64-comparison returns the then-arm — and an ARM leg for the corpus CI never compiled #992 grew the file — not the v0.57.0 release value. I had carried the wrong pair through several working notes. Re-measured at the tag with the ratchet's own marker (
#[cfg(test)]\nmod tests, asserted unique) so the delta is like-for-like.The SPLIT bullet originally read "the root file went 29,616 → 18,284." True release-over-release, but it credits SPLIT with a drop that RETIRE (−1,312) and SELDSL (−79) partly produced. Corrected to SPLIT's own effect: 10,298 lines moved out, 28,533 → 18,284. A locally-true sentence with wrong attribution — the same shape as all four v0.57 errors.
Contents
Cargo.lock—check_version_pins.pyexits 0 at 0.58.0 (30 replacements, 13 files).artifacts/status.json+docs/status/FEATURE_MATRIX.mdvia--emit-status.RQ-58-OBJECTandRQ-58-SPLIT→implemented, completing 11/11.Gates
claim_check.py49/49 ·check_version_pins.py0 ·model_coverage_audit.py --check0 ·cargo fmt --check0.Refs #242.